fix: correctly release buckets#456
Open
dkharms wants to merge 1 commit into
Open
Conversation
59284a4 to
46ab336
Compare
a4a83a7 to
4790c59
Compare
eguguchkin
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One of the nastiest I've ever seen which leads to incorrect accounting of cache-owned memory.
With compaction enabled previous code could overwrite live buckets with other released (or live) buckets leading to x2 cache memory usage.
An example when we lose live buckets:
After the
ReleaseBuckets()we end up withbuckets = [E, B, C]losing bucketD. This bucket will be eventually released because fraction (bucket's owner) is alive and will suicide (therefore callingRelease()) but memory accounting will be broken.Memory accounting will be broken because the generation bucket belongs to will be evicted therefore memory usage of this bucket will not be accounted.
If you have used LLM/AI assistance please provide model name and full prompt: