fix: add .compaction-queue to handle in-mid compaction crash#453
fix: add .compaction-queue to handle in-mid compaction crash#453dkharms wants to merge 3 commits into
Conversation
6c52a39 to
bf68450
Compare
bf68450 to
c66f251
Compare
|
@seqbenchbot up main bulk |
|
@seqbenchbot down 8eedacf8 |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
2168c9a to
452dfe3
Compare
|
@seqbenchbot up main bulk |
|
@seqbenchbot down 1c283919 |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@seqbenchbot up main bulk |
eac5148 to
cc819bd
Compare
|
@seqbenchbot down 36d0de9f |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
cc819bd to
a056057
Compare
a056057 to
c8ce2fd
Compare
|
@seqbenchbot up main mixed |
|
@seqbenchbot down 29d571ac |
|
Nice, @dkharms The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
2211456 to
7b74463
Compare
a41cef1 to
59284a4
Compare
59284a4 to
46ab336
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 70.51% 70.48% -0.04%
==========================================
Files 232 232
Lines 18268 18327 +59
==========================================
+ Hits 12881 12917 +36
- Misses 4426 4446 +20
- Partials 961 964 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Compaction's substitute-and-delete of stale fractions isn't atomic, so a crash mid-compaction could leave source fractions behind and produce duplicates on restart.
This adds a
.compaction-queuefile recording the participating fractions, which is written before merging and used on startup to clean up any leftover sources from an interrupted compaction.If you have used LLM/AI assistance please provide model name and full prompt: