Conversation
Prefer the project-aware handshake and serialize remote document writes. Refresh stale OT state, retry one reconnect, and verify the server snapshot before success. Constraint: Preserve concurrent remote edits through the existing three-way merge. Rejected: Trust the local save result | it can succeed after the OT cache has gone stale. Confidence: high Scope-risk: moderate Directive: Keep remote confirmation mandatory for remote document writes. Tested: TypeScript build, ESLint, OT unit tests, disconnect and multi-file round trips. Not-tested: Self-hosted servers that require the legacy v1 handshake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When the collaboration socket becomes stale or the cached OT version diverges, a remote document write can time out or return without updating the server. The editor may then appear clean even though the remote document still contains the old content.
This change makes a save successful only after a fresh server snapshot matches the merged document. It also reconnects before writing when the underlying Socket.IO transport is disconnected.
Addresses #399.
Validation
npm run compilenpm run lint(passes with two pre-existing warnings)npm run test:unit(2 passing)Compatibility
The legacy v1 handshake remains available as a fallback. The reconnect path has been exercised against Overleaf Cloud; a self-hosted server that requires v1 was not available for manual testing.