Add ortb values for new pause ads by spacanowskiopenx · Pull Request #108 · openx/Prebid.js

spacanowskiopenx · 2026-09-28T08:09:07Z

Type of change

Description of change

Add new oRTB signals according to new oRTB format specification

Be sure to test the integration with your adserver using the Hello World sample page. -->

Other information

github-actions · 2026-09-28T08:10:00Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/adtrueBidAdapter.js has 18 duplicated lines with modules/mediakeysBidAdapter.js
modules/deepintentBidAdapter.js has 15 duplicated lines with modules/mediakeysBidAdapter.js
modules/mediakeysBidAdapter.js has 18 duplicated lines with modules/mediasniperBidAdapter.js
modules/mediakeysBidAdapter.js has 19 duplicated lines with modules/pwbidBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copilot

Copilot review overview

🟡 Changes recommended

Remove unsupported value 7 and add regression coverage for the new signals.

Review effort: Lite
Findings: 1

Open (1)

Add adapter coverage for forwarding new video signal values · New

What changed in this PR

Adds OpenRTB video enum support for pause and screensaver ad signals in the MediaKeys adapter.

Changes:

Expands accepted plcmt, playbackmethod, and pos values.
Updates video parameter validation.

File	Summary
`modules/mediakeysBidAdapter.js`	Remove unsupported `playbackmethod` value `7` and add focused request assertions for the new signals.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: spacanowskiopenx <171801863+spacanowskiopenx@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Add tests for the new values and update outdated OpenRTB documentation.

Review effort: Lite
Findings: 2

Open (2)

Update video parameter documentation for newer enum values · New
Add adapter coverage for forwarding new video signal values

github-actions · 2026-10-19T07:03:02Z

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

Changes to modules/mediakeysBidAdapter.js may need:
- es.iterator.filter
- es.iterator.map
- esnext.iterator.filter
- esnext.iterator.map

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

Copilot

🟡 Changes recommended

The instream example needs to document the configuration required to prevent inline-only VAST bids from being rejected.

1 open issue

Document required VAST caching for inline instream bids · New

2 resolved since last review

_{Review effort: Balanced}

…g for inline instream bids' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Bartłomiej Wąś (KT-Trez)

don't know what's the policy from this repo, but some changes seem to be not tested (ORTB_VIDEO_PARAMS, createBannerImp, createVideoImp)

rest, code-wise LGTM

Bartłomiej Wąś (KT-Trez) · 2026-10-19T08:25:51Z

  maxbitrate: value => isInteger(value),
  boxingallowed: value => [0, 1].indexOf(value) !== -1,
-  playbackmethod: value => Array.isArray(value) && value.every(v => [1, 2, 3, 4, 5, 6].indexOf(v) !== -1),
+  playbackmethod: value => Array.isArray(value) && value.every(v => [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11].indexOf(v) !== -1),


don't we also want to use 1 >= v && v <= 11? looks quite clean

Bartłomiej Wąś (KT-Trez) · 2026-10-19T09:03:04Z

  };
 }

+function addRequestSignals(payload, validBidRequests, bidderRequest) {


I can see that this isn't a widely used practice in the repo, but you could type this function using JSDoc:

https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html#param-and-returns

https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html#typedef-callback-and-param

same for constants inside

example: #108 (comment)

Bartłomiej Wąś (KT-Trez) · 2026-10-19T09:11:34Z

+  const { gdprConsent, uspConsent } = bidderRequest || {};
+  const userExt = cleanObj({
+    consent: gdprConsent?.consentString,
+    eids: deepAccess(validBidRequests[0], 'userIdAsEids')


is it safe to read only the first element of this array, is rest the same?

Yes, it's safe. Every bid in validBidRequests comes from the same bidder request, and core gives them all the same eids value.

Bartłomiej Wąś (KT-Trez) · 2026-10-19T09:28:38Z

-    return banner;
+    return {
+      ...sizeTupleToRtbSize([
+        parseInt(sizes[0][0], 10),


I think this deep array access looks a bit unreadable, could you provide proper typing for the tuple and then destructure it to a named constants?

ex.:

/** * @typedef {[width: number|string, height: number|string]} MediakeysBannerSize */ /** * @typedef {Object} MediakeysBannerBid * @property {{banner: {sizes: Array<MediakeysBannerSize>}}} mediaTypes * @property {{adUnit?: string, pos?: number}} [params] */ /** * Returns an openRtb 2.5 banner object, or undefined when the ad unit has no banner sizes. * * @param {MediakeysBannerBid} bid Prebid bid object from request * @returns {object} */ function createBannerImp(bid) { // ... const [width, height] = sizes[0]; return { ...sizeTupleToRtbSize([parseInt(width, 10), parseInt(height, 10)]), // ... } }

Bartłomiej Wąś (KT-Trez) · 2026-10-19T10:03:43Z

+  const computedParams = Array.isArray(playerSize)
+    ? parseGPTSingleSizeArrayToRtbSize(Array.isArray(playerSize[0]) ? playerSize[0] : playerSize) || {}
+    : {};


can be split to improve a readability a bit

Suggested change

const computedParams = Array.isArray(playerSize)

? parseGPTSingleSizeArrayToRtbSize(Array.isArray(playerSize[0]) ? playerSize[0] : playerSize) || {}

: {};

const [size] = Array.isArray(playerSize?.[0]) ? playerSize : [playerSize];

const computedParams = parseGPTSingleSizeArrayToRtbSize(size) || {};

Co-authored-by: Bartłomiej Wąś <63346093+KT-Trez@users.noreply.github.com>

Add ortb values for new pause ads

24b3475

spacanowskiopenx requested review from PiotrPytlik-openx, Mateusz Król (baramundi666) and monikaopenx (monikaopenx) and a lite review from Copilot September 28, 2026 08:09

Copilot started reviewing on behalf of spacanowskiopenx September 28, 2026 08:09

View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

Comment thread modules/mediakeysBidAdapter.js Outdated

Copilot started work on behalf of spacanowskiopenx September 28, 2026 08:14

View session

Copilot AI and others added 2 commits September 28, 2026 08:19

Core: refactor mediakeys duplicated request builders

82733eb

Co-authored-by: spacanowskiopenx <171801863+spacanowskiopenx@users.noreply.github.com>

Core: preserve mediakeys schain source

59626f8

Co-authored-by: spacanowskiopenx <171801863+spacanowskiopenx@users.noreply.github.com>

Copilot finished work on behalf of spacanowskiopenx September 28, 2026 08:21

spacanowskiopenx requested a lite review from Copilot October 2, 2026 06:42

Copilot started reviewing on behalf of spacanowskiopenx October 2, 2026 06:43

View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Comment thread modules/mediakeysBidAdapter.js Outdated

spacanowskiopenx added 3 commits October 19, 2026 08:50

Add pause ads battr and vast protocols

a7813c9

Update docs

b0fd80f

Merge branch 'master' into pause-ad-ortb

614fd38

spacanowskiopenx requested a balanced review from Copilot October 19, 2026 06:59

Copilot started reviewing on behalf of spacanowskiopenx October 19, 2026 07:00

View session

spacanowskiopenx requested a review from Bartłomiej Wąś (KT-Trez) October 19, 2026 07:00

Copilot AI reviewed Oct 19, 2026

View reviewed changes

Comment thread modules/mediakeysBidAdapter.md

Potential fix for pull request finding 'Document required VAST cachin…

6c62eb5

…g for inline instream bids' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Bartłomiej Wąś (KT-Trez) approved these changes Oct 19, 2026

View reviewed changes

spacanowskiopenx and others added 2 commits October 19, 2026 14:18

Update modules/mediakeysBidAdapter.js

a095ea2

Co-authored-by: Bartłomiej Wąś <63346093+KT-Trez@users.noreply.github.com>

Review changes

84a2c87

Conversation

spacanowskiopenx commented Sep 28, 2026

Type of change

Description of change

Other information

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Bartłomiej Wąś (KT-Trez) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bartłomiej Wąś (KT-Trez) Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bartłomiej Wąś (KT-Trez) left a comment •

edited

Loading

Bartłomiej Wąś (KT-Trez) Oct 19, 2026 •

edited

Loading