pdf2john: accept space-padded xref offsets - #6019
Open
shai20000 wants to merge 1 commit into
Open
Conversation
shai20000
force-pushed
the
fix/pdf2john-space-padded-xref
branch
from
July 22, 2026 15:12
b0fb710 to
131e065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some encrypted PDFs pad their cross-reference table with spaces instead of zeros.
These open fine in normal readers, but
pdf2johnrejected the table and produced an empty hash, so John had nothing to crack. Relax the parser to accept them. Well-formed PDFs are unaffected.Fixes #6018