OCPBUGS-104451: [release-4.22] fix fencing_validator ocdebug fence dispatch race condition by openshift-cherrypick-robot · Pull Request #6360 · openshift/machine-config-operator

openshift-cherrypick-robot · 2026-08-03T09:57:13Z

This is an automated cherry-pick of #6341

/assign Neilhamza

openshift-merge-bot · 2026-08-03T09:57:15Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-03T09:57:16Z

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OCPEDGE-2826

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-03T09:57:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d016004e-746e-4a96-8e72-294a57847e5d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

The fence() function's compound command for the ocdebug transport used `A && B || C & disown`, where the `& disown` was intended only for the nohup fallback (C). However, bash parses `&` as a list terminator that backgrounds the entire AND-OR list, not just the last pipeline. This caused the oc debug pod to exit immediately after backgrounding the compound command, and pod cleanup killed the systemd-run process before it could dispatch the fence unit to systemd. The fence never happened but the script saw exit 0. Replace the `&&/||` compound with an explicit if/else so that `& disown` is correctly scoped to only the nohup fallback branch. Also switch to `--no-block` for systemd-run so it returns immediately after dispatching the unit, avoiding any timeout interaction with the oc debug session. Tested on a live TNF cluster: the patched script successfully fences both nodes sequentially and completes the full disruptive validation, whereas the unpatched script times out waiting for the first node to become NotReady. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Without --collect, a failed or completed transient unit stays loaded and a subsequent fence attempt for the same target would fail because the unit name already exists. Adding --collect alongside --no-block ensures the unit is garbage-collected after completion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Neilhamza · 2026-08-03T10:26:49Z

/test unit

Neilhamza · 2026-08-03T10:39:25Z

/test unit

isabella-janssen

/lgtm
/label backport-risk-assessed

Clean BP

/test unit

openshift-merge-bot · 2026-08-03T12:31:14Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

openshift-ci · 2026-08-03T12:31:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Neilhamza · 2026-08-03T13:29:16Z

/test unit

Neilhamza · 2026-08-03T14:12:41Z

/test unit

Neilhamza · 2026-08-03T14:38:42Z

/test unit

isabella-janssen · 2026-08-03T16:16:35Z

/test unit

Neilhamza · 2026-08-03T17:30:05Z

/test unit

Neilhamza · 2026-08-04T06:27:54Z

/test unit

openshift-ci · 2026-08-04T06:37:53Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Neilhamza · 2026-08-04T06:48:21Z

/verified by ci

Neilhamza · 2026-08-04T06:48:30Z

/jira refresh

openshift-ci-robot · 2026-08-04T06:48:34Z

@Neilhamza: This PR has been marked as verified by ci.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-08-04T06:48:34Z

@Neilhamza: This pull request references OCPEDGE-2826 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.23" instead.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Neilhamza · 2026-08-04T06:50:07Z

/jira refresh

openshift-ci-robot · 2026-08-04T06:50:11Z

@Neilhamza: This pull request references OCPEDGE-2826 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Neilhamza · 2026-08-04T06:55:47Z

/jira refresh

openshift-ci-robot · 2026-08-04T06:55:50Z

@Neilhamza: This pull request references OCPEDGE-2826 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Neilhamza · 2026-08-04T06:57:43Z

/jira refresh

openshift-ci-robot · 2026-08-04T06:57:48Z

@Neilhamza: This pull request references OCPEDGE-2826 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Neilhamza · 2026-08-04T07:02:00Z

/retitle OCPBUGS-104451: [release-4.22] fix fencing_validator ocdebug fence dispatch race condition

openshift-ci-robot · 2026-08-04T07:02:09Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-104451, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-104451 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Neilhamza · 2026-08-04T07:02:23Z

/jira refresh

openshift-ci-robot · 2026-08-04T07:02:28Z

@Neilhamza: This pull request references Jira Issue OCPBUGS-104451, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-104451 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Neilhamza · 2026-08-04T07:04:04Z

/jira refresh

openshift-ci-robot · 2026-08-04T07:04:08Z

@Neilhamza: This pull request references Jira Issue OCPBUGS-104451, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-104451 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Neilhamza · 2026-08-04T07:05:26Z

/jira refresh

openshift-ci-robot · 2026-08-04T07:05:29Z

@Neilhamza: This pull request references Jira Issue OCPBUGS-104451, which is invalid:

expected Jira Issue OCPBUGS-104451 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Neilhamza · 2026-08-04T07:06:32Z

/jira refresh

openshift-ci-robot · 2026-08-04T07:06:39Z

@Neilhamza: This pull request references Jira Issue OCPBUGS-104451, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-104454 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-104454 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-08-04T07:14:06Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-104451
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-104451 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot assigned Neilhamza Aug 3, 2026

openshift-cherrypick-robot mentioned this pull request Aug 3, 2026

OCPEDGE-2826: fix fencing_validator ocdebug fence dispatch race condition #6341

Merged

4 tasks

openshift-ci Bot requested review from jerpeter1 and suleymanakbas91 August 3, 2026 09:57

Neilhamza and others added 2 commits August 3, 2026 10:06

openshift-cherrypick-robot force-pushed the cherry-pick-6341-to-release-4.22 branch from 82b828c to 37382c1 Compare August 3, 2026 10:06

isabella-janssen reviewed Aug 3, 2026

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 3, 2026

openshift-ci Bot assigned anuragthehatter, imatza-rh, mhanss, ptalgulk01, rbbratta, sergiordlr and isabella-janssen Aug 3, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2026

openshift-ci-robot added verified Signifies that the PR passed pre-merge verification criteria jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 4, 2026

openshift-ci Bot changed the title ~~[release-4.22] OCPEDGE-2826: fix fencing_validator ocdebug fence dispatch race condition~~ OCPBUGS-104451: [release-4.22] fix fencing_validator ocdebug fence dispatch race condition Aug 4, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 4, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2026

openshift-merge-bot Bot merged commit 19b3e93 into openshift:release-4.22 Aug 4, 2026
18 checks passed

Uh oh!

Conversation

openshift-cherrypick-robot commented Aug 3, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 3, 2026

Uh oh!

openshift-ci-robot commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Neilhamza commented Aug 3, 2026

Uh oh!

Neilhamza commented Aug 3, 2026

Uh oh!

isabella-janssen left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Aug 3, 2026

Uh oh!

openshift-ci Bot commented Aug 3, 2026

Uh oh!

Neilhamza commented Aug 3, 2026

Uh oh!

Neilhamza commented Aug 3, 2026

Uh oh!

Neilhamza commented Aug 3, 2026

Uh oh!

isabella-janssen commented Aug 3, 2026

Uh oh!

Neilhamza commented Aug 3, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci Bot commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

Neilhamza commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 4, 2026

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

openshift-ci-robot commented Aug 4, 2026 •

edited by openshift-ci Bot

Loading