Skip to content

NO-JIRA: vendor: bump github.com/openshift/api to latest master#3089

Open
mkowalski wants to merge 1 commit into
openshift:masterfrom
mkowalski:vendor-api-bump
Open

NO-JIRA: vendor: bump github.com/openshift/api to latest master#3089
mkowalski wants to merge 1 commit into
openshift:masterfrom
mkowalski:vendor-api-bump

Conversation

@mkowalski

Copy link
Copy Markdown
Contributor

Routine dependency bump of github.com/openshift/api to current master (356624ff).

go get github.com/openshift/api@356624ff && go mod tidy && go mod vendor — no code changes. Bumps k8s.io/{api,apimachinery,client-go} to v0.36.2 as transitive requirements. Build and full pkg test suite pass.


This PR was prepared with AI assistance. Please verify before acting on it.

Assisted-By: Claude Fable 5
Signed-off-by: Mat Kowalski <mko@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@mkowalski: This pull request explicitly references no jira issue.

Details

In response to this:

Routine dependency bump of github.com/openshift/api to current master (356624ff).

go get github.com/openshift/api@356624ff && go mod tidy && go mod vendor — no code changes. Bumps k8s.io/{api,apimachinery,client-go} to v0.36.2 as transitive requirements. Build and full pkg test suite pass.


This PR was prepared with AI assistance. Please verify before acting on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from arkadeepsen and miheer July 24, 2026 08:21
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Walkthrough

The direct github.com/openshift/api dependency in go.mod is updated from its previous pinned version to a newer pinned version.

Changes

OpenShift API dependency update

Layer / File(s) Summary
Update OpenShift API requirement
go.mod
The pinned github.com/openshift/api requirement is updated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tssurya


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Commit Message Quality ❌ Error The lone commit is concise and scoped, but its body is metadata-only and does not explain why the dependency bump is needed. Add a brief explanatory body for the bump’s purpose; keep metadata like sign-off separate from the rationale.
✅ Passed checks (23 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Pr Quality ✅ Passed Vendor bump only: non-vendor changes are just go.mod/go.sum, the title is self-explanatory, and trivial non-functional changes are exempt from the detailed description requirements.
Unit Tests For Go Changes ✅ Passed Only go.mod/go.sum and vendor updates changed; no non-vendor pkg/, cmd/, or bindata/ production files were modified, so no new tests were required.
E2e Tests For Feature Changes ✅ Passed No pkg/ or cmd/ Go source changed; diff is dependency/vendor-only, so the E2E requirement doesn’t apply.
Rbac Least Privilege ✅ Passed The PR only changes go.mod, go.sum, and vendored OpenShift API files; no YAML under bindata/ or manifests/ was modified.
Docs For Feature And Behavior Changes ✅ Passed Pure dependency/vendor bump of github.com/openshift/api; no CNO code or docs/ files changed.
Stale Project Docs And Config ✅ Passed Dependency/vendor bump only; no watched docs/config paths were renamed or deleted, and referenced OpenShift API files still exist.
Go And Test Code Quality ✅ Passed Only go.mod/go.sum changed outside vendor; no production or test Go code was modified, so none of the 9 issues apply.
Ai-Generated Code Smell ✅ Passed Pure dependency/vendor bump; changed files are generated API code/docs, and scans found no AI references, redundant logic, or unrelated tests.
Stable And Deterministic Test Names ✅ Passed No test titles changed; the PR only bumps vendored OpenShift API/generated assets, and the diff adds no Ginkgo It/Describe/Context/When calls.
Test Structure And Quality ✅ Passed PR only updates go.mod/go.sum and vendored dependency files; no Ginkgo test code changed.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests were added or modified; the PR only bumps vendored OpenShift API deps and generated files.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only bumps vendored openshift/api and generated manifests; no Ginkgo e2e tests were added or modified, so no SNO-specific risk.
Topology-Aware Scheduling Compatibility ✅ Passed Only go.mod/go.sum and vendored openshift/api snapshots changed; no first-party manifests, controllers, or scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed PR only bumps go.mod and vendored API files; touched Go files have no package main, init/TestMain, suite hooks, or stdout/logging calls.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only bumps vendored openshift/api go.mod/go.sum and generated vendor files; no new It/Describe/Context/When e2e tests were added.
No-Weak-Crypto ✅ Passed Diff only updates vendored OpenShift API schemas/docs; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret comparisons were added.
Container-Privileges ✅ Passed Touched manifests are vendored CRDs; no changed file adds privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed Diff is a dependency/vendor bump only; no new log calls or sensitive-data strings were added in changed files.
Title check ✅ Passed The title clearly and concisely describes the dependency bump in the affected vendor component.
Description check ✅ Passed The description matches the changeset by explaining the openshift/api dependency update and related transitive bumps.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@rbbratta

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-ovn-upgrade-ipsec
/test e2e-gcp-ovn-techpreview

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fdp-qe
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-ipv6-ipsec
/test e2e-ovn-ipsec-step-registry
/test hypershift-e2e-aks

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski, rbbratta
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkowalski

Copy link
Copy Markdown
Contributor Author

/label approved

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026
@mkowalski

Copy link
Copy Markdown
Contributor Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 24, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@mkowalski: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5c7f864 and 2 for PR HEAD ad3dcdb in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD feb081f and 1 for PR HEAD ad3dcdb in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD cbf6b95 and 0 for PR HEAD ad3dcdb in total

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade ad3dcdb link false /test 5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade-ipsec ad3dcdb link true /test e2e-aws-ovn-upgrade-ipsec
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw ad3dcdb link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/e2e-ovn-ipsec-step-registry ad3dcdb link true /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec ad3dcdb link true /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-aws-ovn-hypershift-conformance ad3dcdb link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp ad3dcdb link true /test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/e2e-aws-ovn-fdp-qe ad3dcdb link true /test e2e-aws-ovn-fdp-qe
ci/prow/e2e-azure-ovn-upgrade ad3dcdb link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/hold

Revision ad3dcdb was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants