MON-4619: Declare KubeStateMetricsTimezonePanic risk for 4.20.z

[shahsahil264]

Summary

Adds conditional update risk for all 4.20.z GA releases (4.20.0 through 4.20.30) to warn clusters upgrading from 4.19.z that kube-state-metrics may crash loop if CronJobs with .spec.timeZone are present.

Root cause: /usr/share/zoneinfo/ is missing from the kube-state-metrics container image. The statically-compiled Go binary panics when time.LoadLocation() fails for timezone-aware CronJobs.

• Affected: 4.20.z, 4.21.z, 4.22.z (confirmed by Benjamin Affolter and Simon Pasquier)
• Not affected: 4.19.z
• Blocked-edges for 4.20.z only: upgrading from 4.20→4.21 or 4.21→4.22 does not increase exposure (affected→affected)
• No fixedIn: fix PRs openshift/kube-state-metrics#147 and #150 still open
• type: Always: no PromQL metric for CronJob timezone usage

Bug

• https://redhat.atlassian.net/browse/OCPBUGS-87957
• Impact statement: https://redhat.atlassian.net/browse/MON-4619

Test plan

• ./hack/validate-blocked-edges.py passes

[openshift-ci-robot]

@shahsahil264: This pull request references Jira Issue OCPBUGS-87957, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Adds conditional update risk for all 4.20.z GA releases (4.20.0 through 4.20.30) to warn clusters upgrading from 4.19.z that kube-state-metrics may crash loop if CronJobs with .spec.timeZone are present.

Root cause: /usr/share/zoneinfo/ is missing from the kube-state-metrics container image. The statically-compiled Go binary panics when time.LoadLocation() fails for timezone-aware CronJobs.

• Affected: 4.20.z, 4.21.z, 4.22.z (confirmed by Benjamin Affolter and Simon Pasquier)
• Not affected: 4.19.z
• Blocked-edges for 4.20.z only: upgrading from 4.20→4.21 or 4.21→4.22 does not increase exposure (affected→affected)
• No fixedIn: fix PRs openshift/kube-state-metrics#147 and #150 still open
• type: Always: no PromQL metric for CronJob timezone usage

Bug

• https://redhat.atlassian.net/browse/OCPBUGS-87957
• Impact statement: https://redhat.atlassian.net/browse/MON-4619

Test plan

• ./hack/validate-blocked-edges.py passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 77414213-471b-41dd-b6dc-d20add630ada

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[shahsahil264]

@wking Can you PTAL!

Thanks

[sdodson]

/hold

I don't want us to block all updates to 4.20 until such a time that we fix this. Please look closer at 4.20.28 and 4.20.29, /usr/share/zoneinfo exists in the former but not the latter. Why?

[sdodson]

https://redhat.atlassian.net/browse/OCPBUGS-87957?focusedCommentId=17692434 has the appropriate affected version ranges.

[shahsahil264]

Updated, narrowed to 4.20.29-30, 4.21.24-25, 4.22.0-6 per your findings
Thanks!

[DavidHurta]

/retitle MON-4619: Declare KubeStateMetricsTimezonePanic risk for 4.20.z

[openshift-ci-robot]

@shahsahil264: This pull request references MON-4619 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Adds conditional update risk for all 4.20.z GA releases (4.20.0 through 4.20.30) to warn clusters upgrading from 4.19.z that kube-state-metrics may crash loop if CronJobs with .spec.timeZone are present.

Root cause: /usr/share/zoneinfo/ is missing from the kube-state-metrics container image. The statically-compiled Go binary panics when time.LoadLocation() fails for timezone-aware CronJobs.

• Affected: 4.20.z, 4.21.z, 4.22.z (confirmed by Benjamin Affolter and Simon Pasquier)
• Not affected: 4.19.z
• Blocked-edges for 4.20.z only: upgrading from 4.20→4.21 or 4.21→4.22 does not increase exposure (affected→affected)
• No fixedIn: fix PRs openshift/kube-state-metrics#147 and #150 still open
• type: Always: no PromQL metric for CronJob timezone usage

Bug

• https://redhat.atlassian.net/browse/OCPBUGS-87957
• Impact statement: https://redhat.atlassian.net/browse/MON-4619

Test plan

• ./hack/validate-blocked-edges.py passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@shahsahil264: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[wking]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shahsahil264, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sdodson]

/hold cancel

Version ranges have been cleared up and represent actual regressed versions. Kube-state-metrics actually fixed their issue in 4.22.7 but we don't know what other coponents are broken and no one has noticed yet. As a result I am happy to wait for the more complete fix of restoring /usr/share/zoneinfo in https://issues.redhat.com/browse/OCPBUGS-99767 and cloned bugs be the one that clears this risk