Repository navigation
Fix splitting results by paramset - #946
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
get_resultsmerged all parameter sets of a method into a single row for runs that follow theparamset_nameconvention ofcommon/nextflow_helpers(e.g.task_predict_modality).get_results: readparamset_namefrom the scores instead ofparamset_id.get_results: parse the paramset from the process tag (<dataset>.<method>[.<paramset>][.<metric>]), so that paramset rows get their run stats and metric components, and failed paramset runs show up.render_report: show each paramset as a separate method (<method>.<paramset>). The report crashed on multiple rows per method.task_results_v4.sh: the dummy paramsets in the test resources now useparamset_nameand have matching trace rows.To do:
resources_test/openproblems/task_results_v4withscripts/create_resources/task_results_v4.shand upload to S3 -- until then the dummy paramsets in the test data are ignored.Issue ticket number and link
n/a
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!