Conversation
…emscripten_async_wget2 deprecation) - Replace emscripten_async_wget2 (deprecated, removed in 6.x) with emscripten_fetch + ASYNCIFY - Add -s ASYNCIFY=1 -s FETCH=1 to config.emscripten.default.mk - Keep fallback to emscripten_async_wget2 for old emscripten (<3) via __EMSCRIPTEN_major__ check - Fix for 6.0.6 where emscripten_async_wget2 is removed, fixes ofLoadImage/ofURLFileLoader sync - Original issue: emscripten_async_wget2 deprecation in ofxEmscriptenURLFileLoader.cpp:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes emscripten_async_wget2 deprecation (removed in 6.x) in ofxEmscriptenURLFileLoader.cpp:27.
Test: emscripten smoke test + ofLoadImage via URL should build and run on 6.0.6.
Related to discussion on asyncify for ofURLFileLoader.