Repository navigation
fix: dark mode text and icon contrast for 1.3.0 - #251
Merged
wernrab merged 1 commit intoNov 4, 2026
Merged
Conversation
Use the existing theme colors for File Details and the remaining low-contrast controls. Add light/dark regression coverage. Assisted-by: Codex:GPT-6
Contributor
Author
|
@guruz for your review when you have time. thanks! |
wernrab
approved these changes
Nov 4, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in OpenCloud Team Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the dark File Details text reported in #23. I also caught a few similar leftovers in the Spaces icon, pattern lock, upload headings, and password/shortcut buttons.
Uses the existing theme colors and removes the button text overrides. Targets
release_1.3.0as discussed in #23.Tested light/dark on Android 8 and 15 emulators, including phone/tablet pattern layouts. Build, 158 unit tests, 11 regression tests per emulator, and Detekt pass.
AI assistance: OpenAI Codex (GPT-6) helped investigate, implement, and test the fixes.