Skip to content

Just show active chevron for sorted table column #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregorydlogan merged 3 commits into from
Sep 21, 2026
Merged

Just show active chevron for sorted table column #1671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c761c12
Just show active chevron for sorted table column
geichelberger Sep 9, 2026
7b4a4b9
Hide chevron if not sorted
geichelberger Sep 15, 2026
c2f076d
Ensure table header sort is accessible
geichelberger Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions src/components/shared/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,13 @@ const TableHeadRows = ({ forceDeselectAll }: { forceDeselectAll: () => unknown }
dispatch(updatePages());
};

const handleSortKeyDown = (event: React.KeyboardEvent, colName: string) => {
if (event.key === "Enter" || event.key === " ") {
event.preventDefault();
sortByColumn(colName);
}
};

return (
<>
{columns.map((column, key) =>
Expand All @@ -245,17 +252,34 @@ const TableHeadRows = ({ forceDeselectAll }: { forceDeselectAll: () => unknown }
"col-sort": reverse !== "NONE" && !!sortBy && column.name === sortBy,
sortable: true,
})}
onClick={() => sortByColumn(column.name)}
aria-sort={
column.name === sortBy
? reverse === "ASC"
? "ascending"
: reverse === "DESC"
? "descending"
: "none"
: "none"
}
>
<span>
<span
role="button"
tabIndex={0}
onClick={() => sortByColumn(column.name)}
onKeyDown={event => handleSortKeyDown(event, column.name)}
>
<span>{t(column.label)}</span>
<div>
<LuChevronUp
className={cn("chevron-up", { active: reverse === "ASC" && column.name === sortBy })}
/>
<LuChevronDown
className={cn("chevron-down", { active: reverse === "DESC" && column.name === sortBy })}
/>
<div className={cn({ "chevron-pair": !(column.name === sortBy && reverse !== "NONE") })}>
{!(column.name === sortBy && reverse === "DESC") && (
<LuChevronUp
className={cn("chevron-up", { active: reverse === "ASC" && column.name === sortBy })}
/>
)}
{!(column.name === sortBy && reverse === "ASC") && (
<LuChevronDown
className={cn("chevron-down", { active: reverse === "DESC" && column.name === sortBy })}
/>
)}
</div>
</span>
</th>
Expand Down
32 changes: 28 additions & 4 deletions src/styles/components/_tables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,20 +181,44 @@
justify-content: center;

.chevron-up {
position: relative;
top: 3px;
color: variables.$color-gray;
}
.chevron-down {
position: relative;
top: -3px;
color: variables.$color-gray;
}
.active {
color: variables.$color-darkgray;
}

&.chevron-pair {
visibility: hidden;

.chevron-up{
position: relative;
top: 3px;
}
.chevron-down {
position: relative;
top: -3px;
}
}
}
}

&.sortable:hover div.chevron-pair,
&.sortable:focus-within div.chevron-pair {
visibility: visible;
}

&.sortable span[role="button"] {
outline: none;
}

&.sortable:focus-within {
outline-style: auto;
outline-color: -webkit-focus-ring-color;
outline-offset: -2px;
}
}

tr {
Expand Down
Loading