Added global- and request scope middleware distinction to documentation#2833
Open
eirikblekesaune wants to merge 1 commit into
Open
Conversation
The implementation supports two types of middleware: global per client instance, and middleware per request. The documentation did not mention this distinction.
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation supports two types of middleware: global per client instance, and middleware per request. The documentation did not mention this distinction.
Changes
Adds section about the distinction between adding middleware to the client instance and to the request call.
This helps users working with server- or BFF-based application to understand the statefulness of middleware for a client instance.
How to Review
Asses whether this addition to the documentation describes the actual implementation in
openapi-typescript/packages/openapi-fetch/src/index.js
Lines 45 to 63 in 0cc7ee7
This adds a conceptual distinction for middleware that is not previously described in the documentation, so ensure that the concepts are rooted in the shared concepts of the contributors.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)