Repository navigation
Improve command groups and add task shortcuts - #379
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 2 mixed files remain; 0 existing customizations changed. Compared 2 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 37691735682 --repo openai/openai-cli \
--name castiron-custom-code-37691735682-1 --dir /tmp/castiron-custom-code-37691735682-1
git apply --stat /tmp/castiron-custom-code-37691735682-1/custom-code.patch
cat /tmp/castiron-custom-code-37691735682-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 60603c545087920cb9f4b68232c77f9b188f5e0d 0eae35722525f84c7ab03d5ba04a50ce60edc608
python3 scripts/castiron/custom_code_report.py report \
--base 60603c545087920cb9f4b68232c77f9b188f5e0d \
--head 0eae35722525f84c7ab03d5ba04a50ce60edc608 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-0eae35722525
cat /tmp/castiron-custom-code-0eae35722525/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f019ed7a35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
saioai
changed the title
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1555b31111
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdc41371ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 19a06bff8f7654969fd015768281b5aefc679c6b. One Bash completion regression needs a fix. The new array lookup aborts normal completion when set -u is enabled.
The task shortcuts reuse decorated handlers and preserve resource identity. Help and completion share ordering without replacing parser categories. I found no further structural issue in those changes.
Validation: source inspection of all 45 changed files and supporting code. Hosted test, build, lint, platform help, and budget checks pass on this commit. I did not run local tests or interactive shell checks.
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Rechecked 0eae35722525f84c7ab03d5ba04a50ce60edc608. The Bash set -u issue is fixed. Missing array entries now expand to an empty value, so normal command completion can continue. The tests cover root, nested, unmatched, and file completion with set -u on and off.
I checked the Bash reload instructions and compared command/help code with the previous review. No further findings.
Validation: source review only. Hosted checks on this commit show 23 passes and four skips. Tests, builds, lint, platform help, and budget checks pass. I did not run local tests or interactive shell checks. Native Bash 3.2/5.3 results are author-reported.
2 participants
Finding a command can require reading long API paths and incomplete help lists. This PR makes groups easier to browse and adds shorter names for common tasks. For example,
openai audio transcriptions createalso works asopenai audio transcribeoropenai transcribe.What changes
transcribe,translate, andspeak, with matching shortcuts at the root. Files getsupload.admin. Theprojectsshortcut opensadmin projects.translateconverts audio into English text.--file=path.openai models lwhenset -uis enabled.Commands
These shorter paths reuse existing functionality. Audio support already existed; this PR changes how users find and invoke it. No new flags are added.
Project and administration requests still require an admin key. The root
--projectoption keeps its existing scope.These existing commands show the help changes:
Help and completion need no API key or network connection. After upgrading, reload shell completion to load the fixes and enable file-path completion.
Code
pkg/customadds shorter routes and descriptions using the existing request handlers. Existing commands keep their names when a shortcut would conflict.internal/clihelpsupplies shared help ordering.internal/autocompletehandles shell completion and checks whether the loaded script supports the new file-path behavior. The smallmain.gochange skips request setup during completion.Generated handlers and dependencies are unchanged. This adds no package. Demo tools remain in
scripts/demos.Tested
Current source:
0eae357. Hosted CI passed: 21 checks passed and two conditional checks were skipped.set -uenabled and disabled.set -uenabled and disabled.main.go vet, dependency verification, and the build passed.Earlier checks at
19a06bfcover unchanged help, request handling, and completion in zsh, fish, and PowerShell.Automated code review found no major issues. Automated security review found no issues on
0eae357.Interactive completion on Windows/Linux remains unverified. No live API calls or paid generation ran.
Demo
Real binaries run in matching macOS Bash terminals, captured as terminal replays. Before uses main
e433bd2. Audio recordings useb5b2a73; their output matches19a06bf. The root After screenshot uses19a06bf. These help demos make no API requests and do not demonstrate shell completion.Audio actions after the change:
Before:
After:
Root help excerpts show the first 32 lines of
openai --help.Before:
After:
Recording recipe · Recorder