Repository navigation
test(workbench): share historical database setup - #1383
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the current diff; no actionable issues found.
kmbroai
left a comment
There was a problem hiding this comment.
Reviewed both changed files against the reviewed parent, historical migration setup, SQL order/constraints/transactions, and callers of the removed internal re-export. All 68 migration tests passed locally. Current CI and discussions inspected. No actionable findings at this commit.
137440d to
467a527
Compare
d4800d9 to
ea28fc2
Compare
467a527 to
7efeb73
Compare
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the current diff; no actionable issues found.
7efeb73 to
d7d3aaf
Compare
ea28fc2 to
d32c32e
Compare
d32c32e to
6451e6d
Compare
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the current diff; no actionable issues found.
Summary
Share historical SQLite setup in migration tests while keeping each legacy schema and upgrade assertion explicit.
Changes
Extract the repeated setup for six historical database scenarios. Use the schema module directly for migration definitions and SQL splitting, and remove the unused workbench SQL-splitter re-export. Preserve the existing fixture helpers and all parameterized migration cases, including the combined profile and public-warning histories. Builds on #1382.
Testing
build:ci, plugin source compatibility, and all nine compatibility checker tests.git diff --check: passed.Risk and rollout
Test refactor plus removal of a test-only internal re-export. Historical migration order, transaction behavior, rejection cases, and repeated-upgrade checks are retained. No new database migration or public API change; no rollout step required.
Public disclosure review