Skip to content

test(workbench): share historical database setup - #1383

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/reduce-16-python-migration-fixtures
Oct 7, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/reduce-16-python-migration-fixtures

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Share historical SQLite setup in migration tests while keeping each legacy schema and upgrade assertion explicit.

Changes

Extract the repeated setup for six historical database scenarios. Use the schema module directly for migration definitions and SQL splitting, and remove the unused workbench SQL-splitter re-export. Preserve the existing fixture helpers and all parameterized migration cases, including the combined profile and public-warning histories. Builds on #1382.

Testing

  • Full migration module on the updated stack: 71 passed.
  • All 43 test functions, parameter lists, decorators, and assertions retained in the source comparison.
  • Required portable source checks passed: Ruff lint and format, TypeScript build:ci, plugin source compatibility, and all nine compatibility checker tests.
  • Independent diff review and git diff --check: passed.

Risk and rollout

Test refactor plus removal of a test-only internal re-export. Historical migration order, transaction behavior, rejection cases, and repeated-upgrade checks are retained. No new database migration or public API change; no rollout step required.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T07:22:31.487519Z 6451e6d New commits
🔒 Security Review ✅ Completed 2026-10-07T07:23:51.893254Z 6451e6d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai mldangelo-oai changed the title test(workbench): share migration fixtures and remove test facade test(workbench): share historical database migration fixtures Oct 7, 2026

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current diff; no actionable issues found.

@kmbroai kmbroai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed both changed files against the reviewed parent, historical migration setup, SQL order/constraints/transactions, and callers of the removed internal re-export. All 68 migration tests passed locally. Current CI and discussions inspected. No actionable findings at this commit.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff and relevant surrounding code at ac9d172. No obvious correctness regressions or lost test coverage found. 68 migration tests passed.

@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/reduce-14-python-deep-fixtures branch from 137440d to 467a527 Compare October 7, 2026 06:27
@mldangelo-oai mldangelo-oai changed the title test(workbench): share historical database migration fixtures test(workbench): share historical database setup Oct 7, 2026
@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/reduce-16-python-migration-fixtures branch 2 times, most recently from d4800d9 to ea28fc2 Compare October 7, 2026 06:36
@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/reduce-14-python-deep-fixtures branch from 467a527 to 7efeb73 Compare October 7, 2026 06:36

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current diff; no actionable issues found.

@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/reduce-14-python-deep-fixtures branch from 7efeb73 to d7d3aaf Compare October 7, 2026 06:57
@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/reduce-16-python-migration-fixtures branch from ea28fc2 to d32c32e Compare October 7, 2026 06:57
Base automatically changed from mdangelo/codex/reduce-14-python-deep-fixtures to main October 7, 2026 07:15
@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Oct 7, 2026
@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/reduce-16-python-migration-fixtures branch from d32c32e to 6451e6d Compare October 7, 2026 07:20

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current diff; no actionable issues found.

@mldangelo-oai
mldangelo-oai merged commit 3a1a51e into main Oct 7, 2026
64 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/reduce-16-python-migration-fixtures branch October 7, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants