Repository navigation
fix: accept the concurrency queue key in the shared actionlint check - #41
Conversation
This points the shared actionlint check at openCoreEMR/actionlint@v1.7.12-oce.3, which accepts the queue key under concurrency. GitHub's workflow syntax defines queue: single|max. Upstream actionlint v1.7.12 rejects it as an unexpected key, and the fix in rhysd/actionlint#654 is unmerged. The oce-ops-infra#217 pull request needs queue: max so a waiting argocd apply request or chart release is never canceled, and its actionlint check fails today. The oce.3 tag carries oce.1, which has the create-github-app-token client-id metadata this pin already used, and it carries oce.2 for the job.workflow_* context properties. It adds the cherry-pick of rhysd/actionlint#654 and a test for an expression group with queue: max. A local build of the tag lints this repository's workflows and oce-ops-infra#217's with no errors. Callers pick it up only when they bump their pin to the release that carries this. Assisted-by: Claude Code
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly describes the main change: updating the shared actionlint check to accept the queue key under concurrency. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🔵 Needs a closer look
The workflow edit is straightforward, but the external fork release’s contents and compatibility could not be independently verified.
No open issues 🎉
What changed in this PR
Updates the shared actionlint workflow to accept concurrency.queue, supporting downstream workflows that need queue: max.
Changes:
- Bumps the OCE actionlint pin from
v1.7.12-oce.1tov1.7.12-oce.3. - Also introduces the fork’s
job.workflow_*context support to callers.
| File | Description |
|---|---|
.github/workflows/actionlint.yml |
Updates the actionlint action version. |
Review effort: Balanced
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This updates the shared actionlint check to accept
queueunderconcurrency. It pins the OCE actionlint build tov1.7.12-oce.3.After merge, the open release PR (#37, 1.1.1) picks this up. Once released, oce-ops-infra bumps its caller pin from 1.0.1 to that release in its own PR, and oce-ops-infra#217 rebases on it.
GitHub defines the key. Upstream actionlint rejects it and its fix at rhysd/actionlint#654 is unmerged. oce-ops-infra#217 needs
queue: maxand its actionlint check is red.The
oce.3build includesoce.2, a cherry-pick of rhysd/actionlint#654, and a test for an expression group withqueue: max. It also bringsoce.2'sjob.workflow_*context support to callers of this workflow for the first time.I verified this locally. The
oce.3build lints this repo's workflows and oce-ops-infra#217's with no errors. The fork's root package tests pass, and one generator-script test fails locally as it does atoce.2.Refs https://github.com/openCoreEMR/oce-ops-infra/pull/217
Fork tag: https://github.com/openCoreEMR/actionlint/tree/v1.7.12-oce.3 (branch
fix/concurrency-queue)Summary by CodeRabbit