Removed entity delete modal#29953
Open
anuj-kumary wants to merge 3 commits into
Open
Conversation
anuj-kumary
added
the
safe to test
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Jest test CoverageUI tests summary
|
Contributor
🟡 Playwright Results — all passed (37 flaky)✅ 4496 passed · ❌ 0 failed · 🟡 37 flaky · ⏭️ 95 skipped
🟡 37 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
… selector The component was updated to use DeleteModal (MUI-based) instead of EntityDeleteModal (Ant Design), which no longer renders .ant-modal-body. Update the selector to data-testid="delete-modal". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review 👍 Approved with suggestions 0 resolved / 1 findingsRefactors the codebase by removing the legacy entity delete modal in favor of a common implementation. Consider restoring the text-input safeguard requiring users to type 'DELETE' to confirm destructive actions. 💡 Edge Case: Delete confirmation no longer requires typing DELETEThe migration from 🤖 Prompt for agentsOptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #
I worked on ... because ...
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Greptile Summary
This PR removes the old entity delete modal and moves the affected delete flows to the shared modal. The main changes are:
EntityDeleteModalcomponent and tests.DeleteModal.Confidence Score: 5/5
This looks safe to merge from the follow-up changes reviewed here.
Important Files Changed
messageprop now accepts rendered content instead of only plain strings.Reviews (2): Last reviewed commit: "Merge branch 'main' into entity-modal-ty..." | Re-trigger Greptile
Context used (3)