chore(tests): move accuracy_tests to functional tests as test_inference#620
Open
tybulewicz wants to merge 2 commits into
Open
chore(tests): move accuracy_tests to functional tests as test_inference#620tybulewicz wants to merge 2 commits into
tybulewicz wants to merge 2 commits into
Conversation
github-actions
Bot
added
tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates and expands inference/accuracy-style coverage by replacing the previous tests/accuracy suite with a new parameterized functional inference test setup, plus updated model-download tooling and CI/docs wiring.
Changes:
- Added
tests/functional/test_inference.pyand new functional scope JSONs to drive broad model inference validation. - Added
tests/functional/download_models.pyand supporting JSON lists for downloading example models/images. - Removed legacy
tests/accuracy/*and updated GitHub Actions + example READMEs/CONTRIBUTING to point at the new functional tooling.
Reviewed changes
Copilot reviewed 15 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| model_api/tests/precommit/public_scope.json | Removed precommit model list (now absent). |
| model_api/tests/precommit/init.py | Removed precommit tests package marker. |
| model_api/tests/functional/test_inference.py | New parameterized functional inference test and result-comparison helpers. |
| model_api/tests/functional/serving_scope.json | New minimal scope JSON for serving-related downloads/tests. |
| model_api/tests/functional/public_scope.json | New full functional test scope with reference outputs. |
| model_api/tests/functional/images.json | New image manifest for downloads/examples. |
| model_api/tests/functional/examples.json | New example model manifest for downloads/examples. |
| model_api/tests/functional/download_models.py | New async downloader for models + datasets used by functional/tests/examples. |
| model_api/tests/functional/conftest.py | Adds CLI options + dump hook for functional inference runs. |
| model_api/tests/accuracy/test_YOLOv8.py | Removed legacy accuracy test. |
| model_api/tests/accuracy/conftest.py | Removed legacy accuracy conftest/options. |
| model_api/tests/accuracy/init.py | Removed legacy accuracy package marker. |
| model_api/examples/zsl_visual_prompting/README.md | Updated download instructions to functional downloader/manifests. |
| model_api/examples/visualization/README.md | Updated download instructions to functional downloader/manifests. |
| model_api/examples/visual_prompting/README.md | Updated download instructions to functional downloader/manifests. |
| model_api/examples/serving_api/README.md | Updated download instructions to functional downloader/manifests. |
| model_api/examples/metrics/README.md | Updated download instructions to functional downloader/manifests. |
| model_api/examples/asynchronous_api/README.md | Updated download instructions to functional downloader/manifests. |
| CONTRIBUTING.md | Updated contributor commands for new functional downloader/tests. |
| .github/workflows/pre_commit.yml | Reworked CI to run unit+functional + serving tests without legacy accuracy job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR relocates inference/accuracy-style coverage by replacing the previous tests/accuracy suite with functional inference test setup, plus updated model-download tooling and CI/docs wiring.
Fixes #597
Before submitting