fix: support 1-channel or 16-bit images in Visualizer#617
Open
tybulewicz wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Visualizer failures when given grayscale (1-channel) or higher-bit-depth (notably 16-bit) images by normalizing inputs into an RGB 8-bit-compatible form before scene generation and rendering, aligning with the behavior expected by downstream PIL operations (e.g., blending).
Changes:
- Add
Visualizer._to_rgb()to convert grayscale inputs to RGB and scale 16-bit / float inputs to 8-bit prior to rendering/showing/saving. - Update
Visualizer.show(),save(), andrender()to consistently route all inputs through_to_rgb(). - Add extensive unit tests covering grayscale, explicit single-channel arrays, 16-bit arrays/PIL images, and float input scaling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| model_api/src/model_api/visualizer/visualizer.py | Adds _to_rgb() normalization and applies it to show/save/render to support grayscale + 16-bit inputs. |
| model_api/tests/unit/visualizer/test_visualizer.py | Adds test coverage for grayscale and 16-bit image handling, plus related blending/stacking expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fdfab94 to
ad1c228
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses Visualizer failures when given grayscale (1-channel) or higher-bit-depth (notably 16-bit) images by normalizing inputs into an RGB 8-bit-compatible form before scene generation and rendering, aligning with the behavior expected by downstream PIL operations (e.g., blending).
Fixes #596
Before submitting