chore: correct documentation links in geti tune cards#614
Merged
Conversation
In case of Apache-2.0 license, the official name is capitalized, but in Hugging Face metadata a lowercased version must be used. This change allows to specify license and license_name separately. What's more, for known case of apache-2.0, correct name will be used automatically.
github-actions
Bot
added
python
Contributor
There was a problem hiding this comment.
Pull request overview
Updates model card/README template generation to use more user-friendly license naming and to correct Geti Tune documentation/source links, aligning generated model cards with updated link targets.
Changes:
- Update multiple README templates to use
<<license_name>>(instead of<<license>>) in Legal information, and adjust Geti links in Geti Tune templates. - Add license-name normalization and inferred “docs page type” (
card/repository/documentation) placeholders during README rendering. - Update several Geti Tune entries in
presets/config.jsonto pointdocsto the original source/model documentation rather than Geti Training Extensions.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| model_converter/src/model_converter/templates/README-torchvision-int8.md | Switch Legal info to <<license_name>>; still needs descriptive “original model repository” link text. |
| model_converter/src/model_converter/templates/README-torchvision-fp16.md | Switch Legal info to <<license_name>>; still needs descriptive “original model repository” link text. |
| model_converter/src/model_converter/templates/README-timm-int8.md | Switch Legal info to <<license_name>>; still needs descriptive “original model card” link text. |
| model_converter/src/model_converter/templates/README-timm-fp16.md | Switch Legal info to <<license_name>>; still needs descriptive “original model card” link text. |
| model_converter/src/model_converter/templates/README-getitune-int8.md | Update Geti links and improve Legal info to reference the original model docs/card/repo. |
| model_converter/src/model_converter/templates/README-getitune-fp16.md | Update Geti links and improve Legal info to reference the original model docs/card/repo. |
| model_converter/src/model_converter/converters/base.py | Add derived placeholders for human license name and inferred docs page label; improve dataset warning message. |
| model_converter/README.md | Document new license_name field in config example (example casing needs adjustment). |
| model_converter/presets/config.json | Update several Geti Tune docs links to point to original upstream sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mgumowsk
reviewed
Jun 29, 2026
mgumowsk
previously approved these changes
Jun 29, 2026
mgumowsk
previously approved these changes
Jun 29, 2026
tybulewicz
force-pushed
the
ttybulew/update-geti-tune-model-cards
branch
from
e263b0f to
256c913
Compare
tybulewicz
force-pushed
the
ttybulew/update-geti-tune-model-cards
branch
from
322a354 to
d170985
Compare
mgumowsk
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates model card/README template generation to use more user-friendly license naming and to correct Geti Tune documentation/source links, aligning generated model cards with updated link targets.
Fixes #612
Before submitting