requesthandler: Fix GtCurrentProgramScene crash - #1353
Open
andrewsoncha wants to merge 1 commit into
Open
andrewsoncha wants to merge 1 commit into
andrewsoncha wants to merge 1 commit into
Conversation
Added checks for a null current program scene in GetCurrentProgramScene. When the current program scene is null, the returning sceneName and sceneUuid are nullptr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added checks for a null current program scene in GetCurrentProgramScene. When the current program scene is null, the sceneName and sceneUuid are returned as None (nullptr).
Motivation and Context
As highlighted in this issue (#1349), OBS to crashes due to a null pointer dereference when the current program scene is deleted and the
GetCurrentProgramSceneRequest is made. This is because there are no guards against null program scenes in the GetCurrentProgramScene RequestHandler code.How Has This Been Tested?
Tested OS(s): MacOS Tanhoe 26.2 (Apple Silicon M2)
The code was tested using the reproduction script included in the issue (#1349). Running the reproduction script did not cause OBS to crash. The output of the reproduction script is as follows:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
masteror arelease/*branch.