Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code and PR description is from a coding agent.
Summary
npm:externalization from Vite's deprecated aliascustomResolverinto the existing Observable plugin.pluginsis assigned after spreadingconfig().npm:resolution, externalization, and non-npm:fallthrough.Why
Vite 8 warns that alias
customResolveris deprecated and will be removed in Vite 9. The recommended replacement is a plugin with aresolveIdhook andenforce: "pre".Keeping the hook on
observable()is important: Notebook Kit's build and preview commands replace thepluginsproperty after spreadingconfig(), so a separate plugin returned only byconfig()would be dropped.Validation
Using Node 24 and pnpm 10, matching CI:
pnpm lint(TypeScript and ESLint)pnpm prepublishOnlypnpm docs:build; realnpm:imports resolve and the deprecation warning is absent