fix(swap): annotate query_strings as string|string[] - #893
Closed
samov0619-prog wants to merge 2 commits into
Closed
fix(swap): annotate query_strings as string|string[]#893samov0619-prog wants to merge 2 commits into
samov0619-prog wants to merge 2 commits into
Conversation
Collaborator
|
duplicate of #892 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M.swap_next and M.swap_previous are annotated ---@PARAM query_strings string, but they pass the argument straight through to swap_textobject, which is annotated string|string[] and unwraps tables natively (if type(query_strings) == 'string' then query_strings = { query_strings } end). A list is the native path — a plain string is the one that gets wrapped.
The parameter name is already plural. move.lua annotates its goto_* functions correctly as string|string[], so only these two are affected.
Passing a list works at runtime but makes lua_ls emit Cannot assign 'table' to parameter 'string' [param-type-mismatch], forcing users to either add ---@diagnostic disable-next-line or cast with --[[@as string]], which is a lie about the actual type.