Support haydenpierce/class-finder ^0.6#2769
Merged
Merged
Conversation
0.6 ships several optimizations that drop the cost of directive class discovery.
Gregory-Gerard
force-pushed
the
bump-classfinder
branch
from
3117932 to
c9f904e
Compare
Collaborator
|
Thanks for the contributions - both upstream and here! Looking forward to the speed bump in my own projects. Released with https://github.com/nuwave/lighthouse/releases/tag/v6.67.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Follow-up to #2768 after the upstream changes landed in https://gitlab.com/hpierce1102/ClassFinder/-/merge_requests/33. 0.6 ships several optimizations that drop the cost of directive class discovery.
Changes
IdeHelperCommandTest+DirectiveLocatorTestgo from ~8.2s to ~0.5s. On my Laravel app,php artisan lighthouse:ide-helpergoes from ~28s to ~1.4s.Breaking changes
None.