Repository navigation
fix: respect gypfile:false when detecting install scripts - #10061
Open
JamieMagee wants to merge 2 commits into
Open
JamieMagee wants to merge 2 commits into
JamieMagee wants to merge 2 commits into
Conversation
JamieMagee
force-pushed
the
fix/gypfile-false-lockfiles
branch
from
October 2, 2026 21:48
fc8a3a2 to
9e4f5b9
Compare
martinrrm
reviewed
Oct 13, 2026
Contributor
Author
|
Strict preflight now uses only incoming metadata and preserves known script bodies. Linked installs sync rebuilt metadata back to logical nodes, including stale |
manzoorwanijk
left a comment
manzoorwanijk
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arborist reads the installed package before inferring
node-gyp rebuild, so lockfile installs respectgypfile: falseand avoid false blocked-script warnings. The fix covers linked installs andscripts: null, with regression tests for stale script flags. Explicit scripts and the lockfile format are unchanged.References
Fixes #9837