Repository navigation
Conversation
Collaborator
|
Review requested:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
inoway46
marked this pull request as ready for review
October 15, 2026 02:22
inoway46
force-pushed
the
investigate-v26-bigjs-deopt
branch
from
October 15, 2026 02:53
77e8e5c to
01baaf5
Compare
inoway46
marked this pull request as draft
November 3, 2026 06:58
inoway46
force-pushed
the
investigate-v26-bigjs-deopt
branch
2 times, most recently
from
November 17, 2026 03:24
9191949 to
646df72
Compare
inoway46
marked this pull request as ready for review
November 17, 2026 06:02
Contributor
Author
|
@nodejs/v8-update This fixes a V8 build configuration issue by aligning our GYP build with V8 14.6's default settings. It was causing the performance regression reported in #66717 (found with big.js), and I've confirmed that this change resolves it both with and without Maglev (verification). |
aduh95
force-pushed
the
v26.x-staging
branch
from
November 17, 2026 13:58
d1a4cf7 to
d7febea
Compare
inoway46
force-pushed
the
investigate-v26-bigjs-deopt
branch
from
November 17, 2026 14:20
646df72 to
af155a5
Compare
legendecas
approved these changes
Nov 17, 2026
aduh95
force-pushed
the
v26.x-staging
branch
2 times, most recently
from
November 17, 2026 15:54
c1cea0a to
4dd7c56
Compare
inoway46
force-pushed
the
investigate-v26-bigjs-deopt
branch
from
November 17, 2026 16:15
af155a5 to
5b79c46
Compare
aduh95
force-pushed
the
v26.x-staging
branch
from
November 17, 2026 16:18
4dd7c56 to
e578ab4
Compare
V8 14.6 enables v8_enable_undefined_double by default in its GN build, but the GYP configuration never set V8_ENABLE_UNDEFINED_DOUBLE, so the default build ran V8 in a non-default configuration. Enabling it eliminates the repeated wrong-map deoptimizations in big.js reported in nodejs#66717. Align the GYP configuration with V8's default, matching the change made on main in 8394db3. Refs: nodejs@8394db3 Fixes: nodejs#66717 Signed-off-by: inoway46 <inoueyuya416@gmail.com> Assisted-by: Codex Assisted-by: Claude Code
inoway46
force-pushed
the
investigate-v26-bigjs-deopt
branch
from
November 17, 2026 16:31
5b79c46 to
4663b6f
Compare
aduh95
force-pushed
the
v26.x-staging
branch
from
November 17, 2026 16:34
e578ab4 to
5cdbf45
Compare
Contributor
Failed to start CIFull Auto Start CI output |
Contributor
Author
|
@legendecas Sorry, I had to rebase this again after v26.x-staging was rewritten, which blocked the CI start. The diff is unchanged. Could you re-approve when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 14.6 enables
v8_enable_undefined_doubleby default, but v26.x, which uses the same V8 14.6, never enabled it in its GYP build. This turned out to be the cause of the performance regression reported in #66717.node/deps/v8/BUILD.gn
Lines 471 to 472 in e315417
I didn't backport 8394db37d800 from main as-is, since it updates the gypfiles for V8 14.8. This PR only adds the undefined double setting.
On macOS arm64, I've confirmed that this builds and that the repro from #66717 no longer hits the deopt loop: https://github.com/inoway46/node/actions/runs/44010080581
Fixes: #66717