Skip to content

stream: more iter streams fixes - #66030

Closed
jasnell wants to merge 7 commits into
nodejs:mainfrom
jasnell:jasnell/moar-iter-streams-2
Closed

stream: more iter streams fixes#66030
jasnell wants to merge 7 commits into
nodejs:mainfrom
jasnell:jasnell/moar-iter-streams-2

Conversation

@jasnell

@jasnell jasnell commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Another round of streams/iter fixes.

Builds on: #66028 ... The first four commits are from that PR. This will remain a draft until that one lands

@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 15, 2026
@jasnell
jasnell requested review from panva and trivikr September 15, 2026 03:54
@jasnell
jasnell marked this pull request as draft September 15, 2026 03:54
@codecov

codecov Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.27790% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.26%. Comparing base (fa95cd5) to head (d0ff99c).
⚠️ Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/streams/iter/from.js 86.25% 32 Missing and 4 partials ⚠️
lib/internal/streams/iter/pull.js 88.23% 6 Missing ⚠️
lib/internal/streams/iter/share.js 90.32% 2 Missing and 1 partial ⚠️
lib/internal/streams/iter/utils.js 93.61% 3 Missing ⚠️
lib/internal/streams/iter/broadcast.js 97.14% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #66030      +/-   ##
==========================================
- Coverage   90.27%   90.26%   -0.01%     
==========================================
  Files         789      789              
  Lines      271623   271894     +271     
  Branches    51847    51911      +64     
==========================================
+ Hits       245196   245416     +220     
- Misses      16910    16951      +41     
- Partials     9517     9527      +10
Files with missing lines Coverage Δ
lib/internal/streams/iter/consumers.js 97.09% <100.00%> (+0.14%) ⬆️
lib/internal/streams/iter/duplex.js 97.47% <100.00%> (+0.25%) ⬆️
lib/internal/streams/iter/broadcast.js 90.50% <97.14%> (+0.33%) ⬆️
lib/internal/streams/iter/share.js 89.32% <90.32%> (-0.20%) ⬇️
lib/internal/streams/iter/utils.js 97.04% <93.61%> (-1.36%) ⬇️
lib/internal/streams/iter/pull.js 83.82% <88.23%> (+0.06%) ⬆️
lib/internal/streams/iter/from.js 87.99% <86.25%> (-0.85%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

panva
panva reviewed Sep 15, 2026
View reviewed changes

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Asssisted-by: Codex

Comment thread lib/internal/streams/iter/share.js Outdated
@jasnell
stream: ensure nested async iterators are cancellation aware
37bec3d 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
stream: make broadcast waiters use SafeSet
4acd6f1 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
stream: ensure protocol and transform accessors are called once
00f4652 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
stream: have broadcast clean factory listeners on cancel
8cc140e 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
stream: ensure streamable protocols precede array/validated-source fa…
efc2f37 
…st paths

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
stream: make Broadcast.from() only return the Broadcast
a409c52 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell force-pushed the jasnell/moar-iter-streams-2 branch from 195c895 to a409c52 Compare September 17, 2026 06:08
@jasnell
jasnell marked this pull request as ready for review September 17, 2026 06:09
@jasnell
stream: update ShareImpl to retain factory abort listener
d0ff99c 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell jasnell mentioned this pull request Sep 17, 2026
Draft
@jasnell
jasnell requested a review from panva September 17, 2026 06:29
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 17, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 17, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2026 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77614/ 💛

@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Sep 18, 2026
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 22, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

     ⚠  0:50     Title should be <= 50 columns.            title-length
     ⚠  0:50     Title should be <= 50 columns.            title-length
     ⚠  0:50     Title should be <= 50 columns.            title-length
  ✖  8f58c737228ed660621836a1e76606ebbb4edd43
     ✖  0:72     Title must be <= 72 columns.              title-length
     ⚠  0:50     Title should be <= 50 columns.            title-length
     ⚠  0:50     Title should be <= 50 columns.            title-length

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
�[36m⠋�[39m Loading data for nodejs/node/pull/66030
�[36m⠋�[39m Loading data for nodejs/node/pull/66030
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66030
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66030
�[36m⠋�[39m Getting comments from nodejs/node/pull/66030
�[36m⠋�[39m Getting commits from nodejs/node/pull/66030
✔  Done loading data for nodejs/node/pull/66030
----------------------------------- PR info ------------------------------------
Title      stream: more iter streams fixes (#66030)
Author     James M Snell <jasnell@gmail.com> (@jasnell)
Branch     jasnell:jasnell/moar-iter-streams-2 -> nodejs:main
Labels     lib / src, author ready, needs-ci, commit-queue, commit-queue-rebase
Commits    7
 - stream: ensure nested async iterators are cancellation aware
 - stream: make broadcast waiters use SafeSet
 - stream: ensure protocol and transform accessors are called once
 - stream: have broadcast clean factory listeners on cancel
 - stream: ensure streamable protocols precede array/validated-source fa…
 - stream: make Broadcast.from() only return the Broadcast
 - stream: update ShareImpl to retain factory abort listener
Committers 1
 - James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 15 Sep 2026 03:53:44 GMT
   ✔  Approvals: 2
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/66030#pullrequestreview-5240110242
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/66030#pullrequestreview-5273752339
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-09-18T16:25:02Z: https://ci.nodejs.org/job/node-test-pull-request/77614/
�[36m⠙�[39m Querying data for job/node-test-pull-request/77614/
�[36m⠙�[39m Querying data for job/node-test-pull-request/77614/
�[36m⠙�[39m Querying API for job/node-test-pull-request/77614/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
�[36m⠹�[39m Querying API for job/node-test-pull-request/77614/
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
�[36m⠹�[39m Querying API for job/node-test-pull-request/77614/
�[36m⠹�[39m Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
�[36m⠸�[39m Downloading patch for 66030
�[36m⠸�[39m Downloading patch for 66030
From https://github.com/nodejs/node
 * branch                  refs/pull/66030/merge -> FETCH_HEAD
✔  Fetched commits as 67a44165dbc4..d0ff99c6694e
--------------------------------------------------------------------------------
[main 1a34c984de] stream: ensure nested async iterators are cancellation aware
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 16:34:29 2026 +0000
 2 files changed, 385 insertions(+), 30 deletions(-)
[main bbfbe59a06] stream: make broadcast waiters use SafeSet
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 16:47:11 2026 +0000
 2 files changed, 45 insertions(+), 8 deletions(-)
 create mode 100644 test/parallel/test-stream-iter-broadcast-waiter-cleanup.js
[main 19e1616863] stream: ensure protocol and transform accessors are called once
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 17:03:00 2026 +0000
 7 files changed, 282 insertions(+), 99 deletions(-)
 create mode 100644 test/parallel/test-stream-iter-property-access.js
[main fe58318ee9] stream: have broadcast clean factory listeners on cancel
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 17:09:45 2026 +0000
 4 files changed, 145 insertions(+), 25 deletions(-)
 create mode 100644 test/parallel/test-stream-iter-factory-signal.js
[main dd1705feee] stream: ensure streamable protocols precede array/validated-source fast paths
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 17:13:53 2026 +0000
 2 files changed, 73 insertions(+), 37 deletions(-)
[main fe7b0ced15] stream: make Broadcast.from() only return the Broadcast
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 17:16:23 2026 +0000
 4 files changed, 16 insertions(+), 6 deletions(-)
[main 2fbededc7e] stream: update ShareImpl to retain factory abort listener
 Author: James M Snell <jasnell@gmail.com>
 Date: Thu Sep 17 06:18:26 2026 +0000
 2 files changed, 25 insertions(+), 2 deletions(-)
   ✔  Patches applied
There are 7 commits in the PR. Attempting autorebase.
(node:586) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: ensure nested async iterators are cancellation aware

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 0bbd780170] stream: ensure nested async iterators are cancellation aware
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 16:34:29 2026 +0000
 2 files changed, 385 insertions(+), 30 deletions(-)
Rebasing (3/14)
Rebasing (4/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: make broadcast waiters use SafeSet

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 1396582b67] stream: make broadcast waiters use SafeSet
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 16:47:11 2026 +0000
 2 files changed, 45 insertions(+), 8 deletions(-)
 create mode 100644 test/parallel/test-stream-iter-broadcast-waiter-cleanup.js
Rebasing (5/14)
Rebasing (6/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: ensure protocol and transform accessors are called once

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 8e6d996789] stream: ensure protocol and transform accessors are called once
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 17:03:00 2026 +0000
 7 files changed, 282 insertions(+), 99 deletions(-)
 create mode 100644 test/parallel/test-stream-iter-property-access.js
Rebasing (7/14)
Rebasing (8/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: have broadcast clean factory listeners on cancel

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 1ef682ea18] stream: have broadcast clean factory listeners on cancel
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 17:09:45 2026 +0000
 4 files changed, 145 insertions(+), 25 deletions(-)
 create mode 100644 test/parallel/test-stream-iter-factory-signal.js
Rebasing (9/14)
Rebasing (10/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: ensure streamable protocols precede array/validated-source fast paths

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 8f58c73722] stream: ensure streamable protocols precede array/validated-source fast paths
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 17:13:53 2026 +0000
 2 files changed, 73 insertions(+), 37 deletions(-)
Rebasing (11/14)
Rebasing (12/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: make Broadcast.from() only return the Broadcast

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 7d6af7ad19] stream: make Broadcast.from() only return the Broadcast
 Author: James M Snell <jasnell@gmail.com>
 Date: Sun Aug 30 17:16:23 2026 +0000
 4 files changed, 16 insertions(+), 6 deletions(-)
Rebasing (13/14)
Rebasing (14/14)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: update ShareImpl to retain factory abort listener

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: https://github.com/nodejs/node/pull/66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 5a0bb93865] stream: update ShareImpl to retain factory abort listener
 Author: James M Snell <jasnell@gmail.com>
 Date: Thu Sep 17 06:18:26 2026 +0000
 2 files changed, 25 insertions(+), 2 deletions(-)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
  ✔  0bbd78017062f09303d9170e4f4598237863eb8f
     ✔  0:0      Assisted-by is a trailer                  assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  3:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
  ✔  1396582b67d8e042acc801640561d186b140b128
     ✔  0:0      Assisted-by is a trailer                  assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  3:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ✔  0:0      Title is <= 50 columns.                   title-length
  ✔  8e6d996789852ab0ef566abf166c62ea32e68e52
     ✔  0:0      Assisted-by is a trailer                  assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  3:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
  ✔  1ef682ea181254796cdad2987a903ae79c294cfc
     ✔  0:0      Assisted-by is a trailer                  assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  3:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
  ✖  8f58c737228ed660621836a1e76606ebbb4edd43
     ✔  0:0      Assisted-by is a trailer                  assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  3:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ✖  0:72     Title must be <= 72 columns.              title-length
  ✔  7d6af7ad19055b31f417a15f28f0df9570036d82
     ✔  0:0      Assisted-by is a trailer                  assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  3:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
  ✔  5a0bb93865a51e457ff7aea3eebe413044e7a5d4
     ✔  0:0      Assisted-by is a trailer                  assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  3:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
--------------------------------------------------------------------------------
   ℹ  Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`

View workflow run

jasnell added a commit that referenced this pull request Sep 22, 2026
@jasnell
stream: ensure nested async iterators are cancellation aware
6fb199a 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: #66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell added a commit that referenced this pull request Sep 22, 2026
@jasnell
stream: make broadcast waiters use SafeSet
665791f 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: #66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell added a commit that referenced this pull request Sep 22, 2026
@jasnell
stream: ensure protocol and transform accessors are called once
e2acffa 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: #66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell added a commit that referenced this pull request Sep 22, 2026
@jasnell
stream: have broadcast clean factory listeners on cancel
2693529 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: #66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell added a commit that referenced this pull request Sep 22, 2026
@jasnell
stream: ensure streamable protocols precede fast paths
85bd860 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: #66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell added a commit that referenced this pull request Sep 22, 2026
@jasnell
stream: make Broadcast.from() only return the Broadcast
d72fb59 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: #66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell added a commit that referenced this pull request Sep 22, 2026
@jasnell
stream: update ShareImpl to retain factory abort listener
3407386 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
PR-URL: #66030
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jasnell

jasnell commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

Landed in 3407386...e898f5c

@jasnell jasnell closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell @nodejs-github-bot @panva @trivikr