Skip to content

test: ensure assertions are reached on all tests#64716

Open
aduh95 wants to merge 4 commits into
nodejs:mainfrom
aduh95:enforce-assert-fixtures
Open

test: ensure assertions are reached on all tests#64716
aduh95 wants to merge 4 commits into
nodejs:mainfrom
aduh95:enforce-assert-fixtures

Conversation

@aduh95

@aduh95 aduh95 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

A number of tests are escaping the linter rules added in 0457bfe and 634dc26 by destructuring assert and/or fixtures.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 24, 2026

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I think you have to fix on test that has a CI failure.

Comment thread test/parallel/test-quic-zero-rtt.mjs Outdated
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (c558c8e) to head (9ab72df).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64716      +/-   ##
==========================================
- Coverage   90.15%   90.12%   -0.03%     
==========================================
  Files         741      743       +2     
  Lines      242251   242324      +73     
  Branches    45624    45631       +7     
==========================================
+ Hits       218391   218397       +6     
- Misses      15351    15411      +60     
- Partials     8509     8516       +7     

see 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants