V22.23.2 proposal

.editorconfig

@@ -16,12 +16,13 @@ end_of_line = crlf
 indent_size = 8
 indent_style = tab
 
-[{deps}/**]
+[deps/**]
 charset = unset
 end_of_line = unset
 indent_size = unset
 indent_style = unset
+insert_final_newline = unset
 trim_trailing_whitespace = unset
 
-[{test/fixtures,deps,tools/eslint/node_modules,tools/gyp,tools/icu,tools/msvs}/**]
+[{test/fixtures,tools/eslint/node_modules,tools/gyp,tools/icu,tools/msvs}/**]
 insert_final_newline = false

.github/actions/undici-wpt-current/action.yml

@@ -0,0 +1,56 @@
+name: Run undici WPT (current)
+description: Runs undici WPT tests for undici >= 7 and merges results into the Node.js WPT report
+
+inputs:
+  undici-version:
+    required: true
+    description: undici version tag to checkout
+  wpt-report:
+    required: true
+    description: Path to the Node.js WPT report to merge into
+
+runs:
+  using: composite
+  steps:
+    - name: Checkout undici
+      uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
+      with:
+        repository: nodejs/undici
+        persist-credentials: false
+        path: undici
+        clean: false
+        ref: ${{ inputs.undici-version }}
+    - name: Prepare WPT checkout
+      shell: bash
+      run: |
+        rm -rf undici/test/web-platform-tests/wpt
+        mv test/fixtures/wpt undici/test/web-platform-tests/wpt
+    - name: Configure hosts
+      shell: bash
+      working-directory: undici/test/web-platform-tests/wpt
+      run: python3 wpt make-hosts-file | sudo tee -a /etc/hosts
+    - name: Install dependencies
+      shell: bash
+      working-directory: undici
+      run: npm install
+    - name: Run WPT
+      shell: bash
+      working-directory: undici
+      env:
+        CI: 'true'
+        WPT_REPORT: ${{ github.workspace }}/undici/wptreport.json
+      run: npm run test:wpt || true
+    - name: Merge report
+      shell: bash
+      env:
+        NODE_WPT_REPORT: ${{ inputs.wpt-report }}
+        UNDICI_WPT_REPORT: ${{ github.workspace }}/undici/wptreport.json
+      run: |
+        if [ -f "$UNDICI_WPT_REPORT" ]; then
+          jq -sc '
+            .[0].results += .[1].results |
+            .[0].time_end = .[1].time_end |
+            .[0]
+          ' "$NODE_WPT_REPORT" "$UNDICI_WPT_REPORT" > "${NODE_WPT_REPORT}.tmp"
+          mv "${NODE_WPT_REPORT}.tmp" "$NODE_WPT_REPORT"
+        fi

.github/actions/undici-wpt-legacy/action.yml

@@ -0,0 +1,37 @@
+name: Run undici WPT (legacy)
+description: Runs undici WPT tests for undici < 7 and appends results to the Node.js WPT report
+
+inputs:
+  undici-version:
+    required: true
+    description: undici version tag to checkout
+  wpt-report:
+    required: true
+    description: Path to the Node.js WPT report
+
+runs:
+  using: composite
+  steps:
+    - name: Checkout undici
+      uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
+      with:
+        repository: nodejs/undici
+        persist-credentials: false
+        path: undici
+        clean: false
+        ref: ${{ inputs.undici-version }}
+    - name: Prepare WPT checkout
+      shell: bash
+      run: |
+        rm -rf undici/test/wpt/tests
+        mv test/fixtures/wpt undici/test/wpt/tests
+    - name: Install dependencies
+      shell: bash
+      working-directory: undici
+      run: npm install
+    - name: Run WPT
+      shell: bash
+      working-directory: undici
+      env:
+        WPT_REPORT: ${{ inputs.wpt-report }}
+      run: npm run test:wpt || true

.github/dependabot.yml

@@ -52,6 +52,8 @@ updates:
       semver-major-days: 5
       semver-minor-days: 5
       semver-patch-days: 5
+      exclude:
+        - '@node-core/doc-kit'
     commit-message:
       prefix: tools
     open-pull-requests-limit: 10

.github/label-pr-config.yml

@@ -104,6 +104,7 @@ subSystemLabels:
   /^lib\/internal\/url\.js$/: whatwg-url
   /^lib\/internal\/modules\/esm/: esm
   /^lib\/internal\/modules/: module
+  /^lib\/internal\/source_map/: source maps
   /^lib\/internal\/webstreams/: web streams
   /^lib\/internal\/test_runner/: test_runner
   /^lib\/internal\/v8\//: v8 module
@@ -128,6 +129,8 @@ exlusiveLabels:
   /^test\/report\//: test, report
   /^test\/fixtures\/es-module/: test, esm
   /^test\/es-module\//: test, esm
+  /^test\/fixtures\/source-map/: test, source maps
+  /^test\/fixtures\/test-426/: test, source maps
   /^test\/fixtures\/wpt\/streams\//: test, web streams
   /^test\/fixtures\/typescript/: test, strip-types
   /^test\/module-hooks\//: test, module, loaders
@@ -214,6 +217,7 @@ allJsSubSystems:
   - url
   - util
   - v8
+  - vfs
   - vm
   - wasi
   - worker

.github/workflows/auto-start-ci.yml

@@ -28,13 +28,13 @@ jobs:
       - name: Get Pull Requests
         id: get_prs_for_ci
         run: >
-          numbers=$(gh pr list \
-                  --repo ${{ github.repository }} \
+          echo "numbers=$(gh pr list \
+                  --repo "$GITHUB_REPOSITORY" \
                   --label 'request-ci' \
                   --json 'number' \
+                  --search 'review:approved' \
                   -t '{{ range . }}{{ .number }} {{ end }}' \
-                  --limit 5)
-          echo "numbers=$numbers" >> $GITHUB_OUTPUT
+                  --limit 5)" >> "$GITHUB_OUTPUT"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   start-ci:
@@ -45,12 +45,8 @@ jobs:
     if: needs.get-prs-for-ci.outputs.numbers != ''
     runs-on: ubuntu-slim
     steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
-        with:
-          persist-credentials: false
-
       - name: Install Node.js
-        uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f  # v6.1.0
+        uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e  # v6.4.0
         with:
           node-version: ${{ env.NODE_VERSION }}
 
@@ -62,15 +58,17 @@ jobs:
           ncu-config set username "$USERNAME"
           ncu-config set token "$GH_TOKEN"
           ncu-config set jenkins_token "$JENKINS_TOKEN"
-          ncu-config set owner "${{ github.repository_owner }}"
-          ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"
+          ncu-config set owner "$GITHUB_REPOSITORY_OWNER"
+          ncu-config set repo "$(echo "$GITHUB_REPOSITORY" | cut -d/ -f2)"
         env:
           USERNAME: ${{ secrets.JENKINS_USER }}
           GH_TOKEN: ${{ secrets.GH_USER_TOKEN }}
           JENKINS_TOKEN: ${{ secrets.JENKINS_TOKEN }}
 
       - name: Start the CI
-        run: ./tools/actions/start-ci.sh ${{ needs.get-prs-for-ci.outputs.numbers }}
+        run: |
+          curl -fsSL "https://github.com/${GITHUB_REPOSITORY}/raw/${GITHUB_SHA}/tools/actions/start-ci.sh" \
+          | sh -s -- ${{ needs.get-prs-for-ci.outputs.numbers }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GH_REPO: ${{ github.repository }}

.github/workflows/build-tarball.yml

@@ -41,11 +41,11 @@ jobs:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-slim
     steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548  # v6.1.0
+        uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405  # v6.2.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -57,7 +57,7 @@ jobs:
           export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
           ./configure && make tar -j4 SKIP_XZ=1
       - name: Upload tarball artifact
-        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4  # v5.0.0
+        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f  # v7.0.0
         with:
           name: tarballs
           path: '*.tar.gz'
@@ -71,24 +71,24 @@ jobs:
       SCCACHE_GHA_ENABLED: ${{ github.base_ref == 'main' || github.ref_name == 'main' }}
       SCCACHE_IDLE_TIMEOUT: '0'
     steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
         with:
           persist-credentials: false
           sparse-checkout: .github/actions/install-clang
           sparse-checkout-cone-mode: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548  # v6.1.0
+        uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405  # v6.2.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Set up sccache
         if: github.base_ref == 'main' || github.ref_name == 'main'
-        uses: Mozilla-Actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad  # v0.0.9
+        uses: Mozilla-Actions/sccache-action@9e7fa8a12102821edf02ca5dbea1acd0f89a2696  # v0.0.10
         with:
           version: v0.12.0
       - name: Environment Information
         run: npx envinfo
       - name: Download tarball
-        uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53  # v6.0.0
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c  # v8.0.1
         with:
           name: tarballs
           path: tarballs

.github/workflows/close-stalled.yml

@@ -20,7 +20,7 @@ jobs:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-slim
     steps:
-      - uses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008  # v10.1.0
+      - uses: actions/stale@b5d41d4e1d5dceea10e7104786b73624c18a190f  # v10.2.0
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           days-before-close: 30