tls: make Server.getTicketKeys throw instead of assert

[nektro]

assert is for invariants and prints a message about the condition being a bug in Node.js if false.
throw ERR_INVALID_ARG_VALUE for publicly facing validation.
this brings it into sync with the validation done in configSecureContext.

[nodejs-github-bot]

Review requested:

• @nodejs/crypto
• @nodejs/net

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (34c28d5) to head (43a4f4e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58365      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.01%     
==========================================
  Files         739      739              
  Lines      241639   241640       +1     
  Branches    45547    45535      -12     
==========================================
- Hits       218031   218030       -1     
- Misses      15152    15153       +1     
- Partials     8456     8457       +1     

Files with missing lines	Coverage Δ
lib/internal/tls/wrap.js	95.10% <100.00%> (+<0.01%)	⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mertcanaltin]

The linter pipeline section seems to be broken.

[nektro]

anything i need to do on my end?

[joyeecheung]

The PR is updatingServer.setTicketKeys but the commit message talks about Server.getTicketKeys instead. Can you update the commit message?

[joyeecheung]

Suggested change

	throw new ERR_INVALID_ARG_VALUE('keys', keys.byteLength, 'must be exactly 48 bytes');
	throw new ERR_INVALID_ARG_VALUE('keys.byteLength', keys.byteLength, 'must be 48 bytes');

The original message looks a bit ambiguous to me by saying "received N" (but N=buffer.byteLength isn't the argument. The buffer is).

[joyeecheung]

Suggested change

	validateBuffer(keys);
	validateBuffer(keys, 'keys');

This predated the PR but since it's adding a test for the message, let's align the two names.

[joyeecheung]

Suggested change

	message: 'The "buffer" argument must be an instance of Buffer, TypedArray, or DataView.' +
	message: 'The "keys" argument must be an instance of Buffer, TypedArray, or DataView.' +

[joyeecheung]

Suggested change

	message: `The argument 'keys' must be exactly 48 bytes. Received ${arg.byteLength}`,
	message: `The property 'keys.byteLength' must be exactly 48 bytes. Received ${arg.byteLength}`,

[github-actions]

This pull request has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

[Ethan-Arrowood]

Hello, I'm doing some backlog hygiene on all PRs related to networking and streaming modules. There hasn't been any activity here for quite a while so I'm going to mark it stalled. It will auto-close in ~30 days. This is not a rejection; if you've like to pick it back up, rebase onto latest main and give me a ping.

Thank you!

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.