Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/node-repo.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,13 @@ async function getDefaultBranch ({ owner, repo, logger }) {
function getCodeOwnersFile (url, { logger }) {
return new Promise((resolve, reject) => {
https.get(url, (res) => {
res.on('error', (err) => {
logger.error(err, 'Error retrieving OWNERS')
return reject(err)
})
if (res.statusCode !== 200) {
// discard the response body so the socket is released
res.resume()
Comment thread
Trott marked this conversation as resolved.
Resolved
Comment thread
Trott marked this conversation as resolved.
Resolved
logger.error(`Status code: ${res.statusCode}`, 'Error retrieving OWNERS')
return reject(res.statusCode)
}
Expand All @@ -127,7 +133,7 @@ function getCodeOwnersFile (url, { logger }) {
res.on('end', () => {
return resolve(body)
})
}).on('err', (err) => {
}).on('error', (err) => {
logger.error(err, 'Error retrieving OWNERS')
return reject(err)
})
Expand Down
51 changes: 51 additions & 0 deletions test/unit/node-repo-owners.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import test from 'node:test'
import { Readable } from 'node:stream'
import fetchMock from 'fetch-mock'
import nock from 'nock'

Expand Down Expand Up @@ -169,6 +170,56 @@ test('getCodeOwnersFile fail', async (t) => {
scope.done()
})

test('getCodeOwnersFile network error', async (t) => {
const options = {
owner: 'nodejs',
repo: 'node-auto-test-6',
prId: 12347,
logger: { info: () => {}, error: () => {}, debug: () => {}, child: function () { return this } },
retries: 1,
defaultBranch: 'main',
retryInterval: 10
}

const base = 'https://localhost'
const filePath = '/CODEOWNERS'
const url = `${base}${filePath}`
const scope = nock(base)
.get(filePath)
.replyWithError('socket hang up')

await t.assert.rejects(getCodeOwnersFile(url, options), { message: 'socket hang up' })
scope.done()
})

test('getCodeOwnersFile handles an interrupted error response', async (t) => {
const errors = []
const options = {
logger: { error: (...args) => errors.push(args) }
}
let sent = false
const response = new Readable({
read () {
if (sent) return
sent = true
this.push('partial response')
setImmediate(() => this.destroy(new Error('socket hang up')))
}
})
const base = 'https://localhost'
const filePath = '/CODEOWNERS'
const scope = nock(base)
.get(filePath)
.reply(500, () => response)

await t.assert.rejects(getCodeOwnersFile(`${base}${filePath}`, options))
await new Promise(resolve => setImmediate(resolve))

t.assert.strictEqual(errors.length, 2)
t.assert.ok(errors[1][0] instanceof Error)
scope.done()
})

test('pingOwners success', async (t) => {
const options = {
owner: 'nodejs',
Expand Down
Loading