Skip to content

chore: eliminate lint warnings - #1145

Open
btea wants to merge 1 commit into
nodejs:mainfrom
btea:chore/fix-lint-warn
Open

btea wants to merge 1 commit into
nodejs:mainfrom
btea:chore/fix-lint-warn

Conversation

@btea

@btea btea commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Description

When running node --run lint, the following warning message will appear.

image

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@btea
btea requested a review from a team as a code owner October 2, 2026 07:16
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Oct 2, 2026 7:17am UTC

Request Review

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 2.8% slower (1.43 s → 1.47 s)
  • Peak memory: 0.6% lower (423.48 MB → 420.81 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 2.9% slower (10.17 s → 10.47 s)
  • Peak memory: 15.7% higher (1.45 GB → 1.67 GB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 45.4% slower (28.34 s → 41.22 s)
  • Peak memory: 0.6% lower (2.45 GB → 2.44 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 15.6% slower (6.43 s → 7.43 s)
  • Peak memory: 2.5% lower (1.58 GB → 1.54 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 24.3% faster (6.83 s → 5.17 s)
  • Peak memory: 4.3% higher (1.56 GB → 1.63 GB)

orama-db Generator

Performance estimate (single CI run)

  • Generation time: 0.8% slower (6.41 s → 6.46 s)
  • Peak memory: 8.3% higher (1.63 GB → 1.76 GB)

web Generator

Performance estimate (single CI run)

  • Generation time: 27.8% slower (51.81 s → 66.23 s)
  • Peak memory: 10.5% higher (3.25 GB → 3.59 GB)

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.64%. Comparing base (c5a3fe8) to head (9533c49).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1145   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         244      244           
  Lines       23113    23113           
  Branches     2263     2263           
=======================================
  Hits        21412    21412           
  Misses       1692     1692           
  Partials        9        9           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should actually address the issue? Can we maybe instead of using index, use a base64 of segment?

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 9533c492 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants