Tests: map regex with location captures. - #81
Open
Aayush7352 wants to merge 1 commit into
Open
Conversation
Test that a map variable with a regex pattern does not overwrite request capture state ($1, $2) set by a location regex.
Author
|
Updated companion test PR #82 adds further coverage for ticket #357 (map regex capture $1 in rewrite replacement). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression test for nginx/nginx#1573 / nginx/nginx#244: map variable with regex must not overwrite request capture state ($1, $2, ...) set by location regex.
What the test covers
mapwith~/.+$regex pattern + regex location with captures →$1,$2have correct valuesVerified
All 5 subtests pass with the fix from nginx/nginx#1573. Without the fix, 4/5 fail --
$1and$2are empty and Content-Length is over-counted.Related: nginx/nginx#244, nginx/nginx#1573