Tests: custom PROXY protocol v2 TLVs sent to backends. - #110
Open
fatpat wants to merge 1 commit into
Open
Conversation
9 tasks
Tests for the "proxy_protocol_v2_tlv" directive in stream and mail. The backend is a Perl daemon that parses the PROXY protocol header itself, so the TLVs are checked as written on the wire; this tells a zero-length TLV apart from an absent one, which reading them back through $proxy_protocol_tlv_* cannot. Also covers the accepted type notation and the rejection of duplicate types, by running "nginx -t" over generated configurations. Assisted-by: Claude:claude-opus-5
fatpat
force-pushed
the
proxy_protocol_v2_tlv
branch
from
August 27, 2026 18:48
85aadb5 to
8fe2c73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Tests for the "proxy_protocol_v2_tlv" directive in stream and mail. The backend is a Perl daemon that parses the PROXY protocol header itself, so the TLVs are checked as written on the wire; this tells a zero-length TLV apart from an absent one, which reading them back through $proxy_protocol_tlv_* cannot.
Also covers the accepted type notation and the rejection of duplicate types, by running "nginx -t" over generated configurations.
test for changes from nginx/nginx#1698
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).