Merge stable32 into main branch - #497
Merged
Merged
Conversation
nmc/5139-new-breadcrumb-design
Updated the date filter button in the unified search modal to match the filter dropdown button design from the files app. Changes include: - Applied blue button styling with proper hover/active/expanded states - Changed button text from "Date" to "Modified" using CSS - Added CSS-generated dropdown arrow with rotation animation - Improved padding and alignment for better visual consistency - Hidden the calendar icon to match the simplified design - Added decorative empty state image for search results
Update search modal header to use flexbox layout for better alignment of filter buttons and applied filter chips. Position filter chips inline with buttons instead of below them.
Update input field styling for better user experience: - Change border radius to use container radius variable - Add black border in normal state, grey on hover/focus - Add grey background on hover, focus, and active states - Add black focus ring with 3px offset - Hide label on hover and focus - Add 6px left margin to dialog name and header
- Add custom background colors to "Load more results" button (#D2E2FC normal, #ECF3FE hover) - Change result title text to black with large font size - Add font-size-title-large variable for consistent typography - Remove padding from result list items - Add new color variables for theme-adaptive text colors
- Add background color on hover/focus/active for search input - Create background-input-hover-focus variable in nmcdefault.scss - Update header margin to use consistent spacing - Add theme-adaptive text color variables
- Center label vertically in input field - Add smooth transition animation when label moves to top on focus/hover - Set label to smaller font size and position at top when active - Use transparent background for floating label
style: update search modal filter button styling
…uts-in-the-media-area icons made fully usable in both light and dark theme
- Add responsive breakpoints for modals on mobile and tablet devices - Update checkbox/radio hover and focus background color to be lighter - Remove bottom margins from settings sections for better spacing - Reduce modal padding on small screens for better mobile UX
…lay-settings-design
Simplify flexbox layout to allow content scrolling while preserving close button functionality.
- Add babel-loader and node-polyfill-webpack-plugin to resolve build errors - Change favorite star color to yellow (#FFD43B) for better visibility
…-design nmc/5104-new-display-settings-design
The modal-container__content element was receiving overflow-y: auto via the NMC theme override, turning it into a scroll container. On Android Chrome, this scroll container intercepts touch events in its rendered bounds — which overlaps with the absolutely-positioned close button (top: 0.5rem, right: 0.5rem). As a result, tapping the X button had no effect on Android tablets (tested on Samsung Galaxy Tab A8 / Android 14 and Lenovo Tab M10 / Android 12). NcDialog intentionally sets modal-container__content to overflow: hidden and handles scrolling one level deeper at dialog__content. The NMC override was defeating this by making the outer container a touch scroll target. Fix: separate the combined &__content, .dialog__content selector so that overflow-y: auto only applies to .dialog__content (where scrolling belongs), leaving modal-container__content without an overflow override. NcDialog's own scoped CSS (overflow: hidden) now applies correctly, eliminating the touch event interception on Android.
…tion-date-field-size-is-too-big nmc/5798-files-sharing-expiration-date-field-size-is-too-big
…opup-does-not-close-after-tapping-X-button-in-Photo-Settings nmc/5917-android-add-folder-popup-does-not-close-after-tapping-X-button-in-Photo-Settings
When the user typed a search term and clicked outside the input, the floating label snapped back to center and covered the typed text, making it appear as if the value had disappeared. Added :has(:not(:placeholder-shown)) so the label stays floated and padding-top is maintained whenever the input contains a value, regardless of focus state.
AC1 - Header (Settings menu): - UserMenu.vue: replace invalid <div> wrapper with <template> inside <ul> - UserMenu.vue: add aria-label with "opens in new tab" hint on external links (Hilfe & FAQ, Kundencenter) so screen readers announce the context AC4 - Storage indicator: - StorageQuota.vue: add aria-label="Expand storage, opens in new tab" on the storage upgrade link to inform screen readers it opens a new tab - StorageQuota.vue: add aria-hidden="true" on NcIconSvgWrapper to prevent the decorative icon from being announced by screen readers Translations: - Add "opens in new tab" key to en, en_GB, de, de_DE l10n files - Add "Expand storage, opens in new tab" key to all four l10n files
…-loading-bar-position Nmc/6235 android files change loading bar position
…-disappearing nmc/5802-search-term-randomly-disappearing
…white-overlapping-borders-shown-after-folder-renaming Nmc/5782 web files black and white overlapping borders shown after folder renaming
…ility-labels fix: add missing accessibility labels in header and storage quota
After permanently deleting or restoring files from the trashbin, the "N selected" overlay persisted until page reload. This adds a MutationObserver that watches for the table's empty state class and programmatically clicks Cancel to reset the Vue selection store.
The core files app hides "Rename" for every item in the Favorites view because its enabled() check requires the real parent folder to have CREATE permission. Favorites is a flattened list aggregating items from many different folders, so no single real parent is resolvable, and the check always fails there. Patch the rename action's enabled() at runtime, scoped to the favorites view only, to fall back to the node's own DELETE + UPDATE permission bits instead of the parent folder's permissions. All other views keep the original, unmodified behavior.
…ected-still-shown-after-clearing-the-bin nmc/5775-Trash-bin-Text-x-selected-still-shown-after-clearing-the-bin
…ion-missing nmc/5903-favorites-rename-option-missing
On Android Chrome, vh units resolve against the large viewport (address bar hidden), so the modal and dialog content were sized taller than the actually visible area whenever the address bar was shown. This pushed the results list, including the "Load more results" footer, below the fold and made it unreachable when a search matched many files. Switch the modal and unified search dialog height constraints from vh to dvh so they track the real visible viewport as the address bar shows and hides. Also remove a mobile-only override that reset the modal container's flex-direction back to row and let it scroll itself, which collapsed the vertical layout the dialog relies on for its sticky header and scrollable results region.
…ownload button icon
The subname line in the app sidebar header used nowrap/ellipsis on a flex container, so the ellipsis never rendered and the date was hard-clipped on narrow viewports. Allow the metadata row to wrap instead so the full date stays visible.
…ge-access-screen-is-cut nmc/5785-date-inside-the-manage-access-screen-is-cut
…on-ticket-1.2 added a scrollbar in email sharing detail view and fixed guest view download button icon
…main-app-content nmc/6391-Web-round-corner-in-main-app-content
…arch-is-not-showing-all-results fix: unified search results cut off on Android browser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.