fix: accessibility for apperance#62489
Conversation
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
bdd1aba to
cd5393a
Compare
| alt="" | ||
| class="theming__preview-image" | ||
| :src="imageUrl" | ||
| <button |
There was a problem hiding this comment.
This is not valid you cannot have a checkbox inside a button.
This should be just a DIV element and checkbox within already is the semantic input element.
There was a problem hiding this comment.
So the outer elements needs to be a div and the outer fieldset needs a role="radiogroup".
|
|
||
| <div :class="$style.backgroundSelect"> | ||
| <!-- Custom background --> | ||
| <ul |
There was a problem hiding this comment.
why?
This is semantically not really correct, fieldset already was correct.
As this is a group of related input fileds. Its not really a list.
There was a problem hiding this comment.
https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1624
Related to this feedback, they want the background to be HTML list.
There was a problem hiding this comment.
But thats invalid see my feedback on the issue. IMHO a false-positive text and should be closed as wont fix with proper reference to WCAG rules as the current semantics are correct (expect my other comment above).
susnux
left a comment
There was a problem hiding this comment.
See my comment - parially the issue is wrong as semantics for WCAG needs radiogroup and radio within the theme selection.
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)