refactor(files_sharing): clarify failed shared-storage cache handling#62485
Draft
joshtrichards wants to merge 1 commit into
Draft
refactor(files_sharing): clarify failed shared-storage cache handling#62485joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed shared storage uses
FailedCache’s synthetic root entry and is denied through normal permission checks.This change acknowledges that
ICache::get()can returnfalse, caches that result, and makesisValid()explicitly deny access in that case. This prevents a cache miss from becoming a method call onfalse, while documenting why the normalFailedStoragepath remains safe.Changes:
false.getById()miss.Depends on/related to: PR #62484
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)