fix(view): make removeMount locking cleanup exception-safe#62465
Draft
joshtrichards wants to merge 2 commits into
Draft
fix(view): make removeMount locking cleanup exception-safe#62465joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuing my efforts to eliminate more "lock acquired, then an exception bypasses cleanup" pattern from another spot in the code base.
Make
removeMount()release its lock on every exit.This protects against exceptions from the
umounthook,changeLock(),IMovableMount::removeMount(), orpost_umounthook.Also preserves non-cleanup exceptions and passes them on.
Why
removeMount()/ movable-mount cleanup is not exception-safe:removeMount()acquires a shared mount-point lock, emits anumounthook, promotes the lock to exclusive, callsremoveMount(), downgrades, emits the post-hook, then unlocks.changeLock(), or the mount’sremoveMount()implementation throws, neither the downgrade nor unlock is guaranteed. Atry/finallyshould protect that sequence.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)