Repository navigation
Conversation
The term was put into the filter string unencoded, and the filter string is split on spaces and colons. Searching "QA invite" therefore only searched for "QA", and "Re: invoice" for "Re". Values are now URL encoded, which the filter string parser already decodes. Person filter addresses are encoded too, so a "+" in an address is no longer turned into a space. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
GVodyanov
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
November 1, 2026 22:43
Contributor
|
Thanks, I prepare a patch for a similar problem, but forgot about it #14008 🙈 Could you please switch this PR to rawurlencode and trim the term before encoding? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mail's unified search provider only searched for the first word of the term. Searching "QA Invite" searched for "QA", and "Re: invoice" for "Re", so results included every message containing that first word.
FilteringProviderput the term into the filter string unencoded, and that string is split on spaces and colons. The term and the person filter addresses are now URL encoded, which the filter string parser already decodes. Encoding the addresses also keeps a+in an address from turning into a space.How to test
Found during the QA round in #13797. AI-assisted (Claude Code); reviewed and tested by me.
🤖 AI (if applicable)