Repository navigation
Conversation
PHP type names are case-insensitive, but Type recognized only the
lowercase spelling:
- Type::fromString('MIXED')->with('null') produced '?MIXED', which PHP
rejects, because allows() did not treat MIXED as mixed
- Type::fromString('NULL|int') stayed 'NULL|int' and was not recognized
as the simple nullable type '?int'
fromString('?mixed') now gives 'mixed', as fromReflection() does.
…oked before return are marked @param-immediately-invoked-callable PHPStan assumes callables passed to methods are invoked later, so checked exceptions thrown inside them were not attributed to the caller. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan assumes a callable passed to a method may run later. So with missingCheckedExceptionInThrows enabled, a checked exception thrown inside e.g.
Arrays::some($items, fn() => throw new \Exception)goesunreported. phpstan-nette worked around this with stubs; this adds the tag natively.
Tagged:
Only phpdoc changes. TypesTest.phpt asserts one missing-@throws report per tagged call and none for the lazy controls.