fix: a google maps api key is hardcoded directly in ... in GoogleMaps.js - #48873
Closed
anupamme wants to merge 1 commit into
Closed
fix: a google maps api key is hardcoded directly in ... in GoogleMaps.js#48873anupamme wants to merge 1 commit into
anupamme wants to merge 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
ZeeshanTamboli
left a comment
Member
There was a problem hiding this comment.
I don't think it's an issue or a safety concern. The API key is just for the demo purpose.
Author
|
You're right; thanks for taking a look. I should have caught that Maps JS API keys are meant to be client-exposed and are secured via HTTP referrer restrictions rather than secrecy, not treated as a secret to hide. Apologies for the noise; closing this out on my end too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
docs/data/material/components/autocomplete/GoogleMaps.js.Vulnerability
V-001docs/data/material/components/autocomplete/GoogleMaps.js:18Description: A Google Maps API key is hardcoded directly in the frontend JavaScript code, exposing it to anyone who views the page source or inspects the JavaScript bundle. The comment acknowledges this is for demo purposes, but the key remains exposed in production code.
Evidence
Exploitation scenario: An attacker visits the documentation site, opens browser developer tools, searches for 'AIzaSy' (common Google API key prefix), extracts the API key, and uses it to make unauthorized Google Maps API.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Node.js library - vulnerabilities affect downstream consumers who use this package.
Changes
docs/data/material/components/autocomplete/GoogleMaps.jsBehavior Preservation
The change is scoped to 1 file on the vulnerable path, and the project's existing tests still pass, so intended behavior is unchanged.
Verification
Security Invariant
Regression test
This test guards against regressions — it's useful independent of the code change above.
Automated security fix by OrbisAI Security