Bug 2034431 - Add support for labeled probes in telemetry alerting. - #9734
Open
gmierz wants to merge 5 commits into
Open
Bug 2034431 - Add support for labeled probes in telemetry alerting.#9734gmierz wants to merge 5 commits into
gmierz wants to merge 5 commits into
Conversation
gmierz
commented
Jul 29, 2026
| from_build_date=str( | ||
| (probe_signature.created - timedelta(days=30)).strftime("%Y-%m-%d") | ||
| ), | ||
| # Labeled probes hold one timeseries per label so each of them |
Collaborator
Author
There was a problem hiding this comment.
Just a note that I'm not happy with how this code is looking but I didn't want to make this PR bigger. I'll implement a different approach in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the necessary changes to support labeled probe types in telemetry alerting. A DB change is needed for the signature uniqueness to include labels as part of them since each probe+label combination is a unique time series. The commands are also updated to support labeled probes at the same time along with a new --force-monitor option so that we can test alerting on probes that don't have a monitor field defined on them yet (useful for testing new probe types).