Skip to content

Bug 2058880 - Graphs View - Add a dropdown which includes all the highlight buttons - #9733

Open
davidmiculit wants to merge 4 commits into
mozilla:masterfrom
davidmiculit:feat/highlight-options-dropdown
Open

Bug 2058880 - Graphs View - Add a dropdown which includes all the highlight buttons#9733
davidmiculit wants to merge 4 commits into
mozilla:masterfrom
davidmiculit:feat/highlight-options-dropdown

Conversation

@davidmiculit

Copy link
Copy Markdown
Collaborator

@esanuandra esanuandra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread ui/perfherder/graphs/HighlightOptionsDropdown.jsx Outdated
Comment thread tests/ui/perfherder/graphs-view/graphs_view_test.jsx
Comment thread tests/ui/perfherder/graphs-view/graphs_view_test.jsx Outdated
Comment thread tests/ui/perfherder/graphs-view/graphs_view_test.jsx Outdated
Comment thread ui/perfherder/graphs/HighlightOptionsDropdown.jsx Outdated
Comment thread ui/perfherder/graphs/HighlightOptionsDropdown.jsx Outdated
Highlight initial data points
</Button>
<Col sm="auto" className="ps-0 d-flex align-items-center">
<HighlightOptionsDropdown

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to move to button in next to "Last 14 days" or "Add test data" - I think you cold ask about the position on the element channel with a few different screenshots

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change. I think the highlight button should stay together with the highlight revision inputs.

@netlify

netlify Bot commented Aug 10, 2026

Copy link
Copy Markdown

Deploy Preview for treeherder ready!

Name Link
🔨 Latest commit 00a56cf
🔍 Latest deploy log https://app.netlify.com/projects/treeherder/deploys/6a79c3a8cfc9ef00084d444d
😎 Deploy Preview https://deploy-preview-9733--treeherder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants