Show the commits of a Lando landing job while waiting for the push. - #9732
Open
fqueze wants to merge 1 commit into
Open
Show the commits of a Lando landing job while waiting for the push.#9732fqueze wants to merge 1 commit into
fqueze wants to merge 1 commit into
Conversation
fqueze
force-pushed
the
lando-push-display
branch
from
July 28, 2026 20:18
cce37ff to
bd21add
Compare
The newer Lando instances return the requester, the submission date and the commits of a landing job, so display them with the layout of a real push instead of a one line "Waiting for push with lando commit ID" message. The commit rows reuse RevisionList, with a new hideCommitSha option as the commits have no hash to show or link to until they have landed. Instances that don't return commits (and failed requests) still get the previous message; nothing is displayed until the landing job has been fetched, to avoid flashing that message on load.
fqueze
force-pushed
the
lando-push-display
branch
from
July 28, 2026 20:55
bd21add to
584cdbc
Compare
Collaborator
Author
|
Failed landing, before: after: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since mozilla-conduit/lando#1100, the newer Lando instances return the requester, the submission date and the commits of a landing job, so display them with the layout of a real push instead of a one line "Waiting for push with lando commit ID" message.
The commit rows reuse RevisionList, with a new hideCommitSha option as the commits have no hash to show or link to until they have landed.
Instances that don't return commits (and failed requests) still get the previous message; nothing is displayed until the landing job has been fetched, to avoid flashing that message on load.
Before:
After:
