Prevent Scanner From Blocking Auto-approval - #25258
Draft
chrstinalin wants to merge 1 commit into
Draft
Conversation
chrstinalin
marked this pull request as draft
August 6, 2026 15:40
willdurand
reviewed
Aug 7, 2026
| and summary.scanner_actions_executed is not False | ||
| ) | ||
| if already_executed: | ||
| if version.channel == amo.CHANNEL_ENTERPRISE: |
Member
There was a problem hiding this comment.
From a cursory look, nothing wrong with that but I am wondering whether we should do this check in run_actions() directly:
addons-server/src/olympia/scanners/models.py
Line 462 in 821d9eb
Contributor
Author
There was a problem hiding this comment.
Is there any case where scanners would need to be run manually on a specific add-on?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to mozilla/addons#14853
Description
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.