Skip to content

DRIVERS-3601 Push release refs atomically #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 2 commits into from
Sep 3, 2026
+14 −6
Merged

DRIVERS-3601 Push release refs atomically #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0af6951
Push the version-bump commit and tags atomically
blink1073 Sep 3, 2026
9902c2e
Update release workflow to use dynamic branch and tag
blink1073 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ jobs:
with:
version: ${{ env.NEXT_VERSION }}
version_bump_script: "bash .github/scripts/bump-major-version.sh"
push_commit: ${{ inputs.dry_run == false }}
push_commit: false

- name: Tag the version
uses: $/tag-version
with:
version: ${{ env.NEXT_VERSION }}
tag_template: "v${VERSION}"
push_tag: ${{ inputs.dry_run == false }}
push_tag: false

- name: Report floating v3 tag update (dry run)
if: env.IS_V3 == 'true' && inputs.dry_run == true
Expand All @@ -96,17 +96,25 @@ jobs:
with:
command: git tag -a "v3" -f -m "Update tag" -s --local-user=${{ env.GPG_KEY_ID }}

- name: Push the v3 tag
if: env.IS_V3 == 'true' && inputs.dry_run == false
# Everything above this point is created and verified locally without touching the
# remote. Pushing the branch and both tags together, atomically, means a failure here
# leaves the remote exactly as it was before this run, so a plain rerun is always safe.
- name: Push release refs
if: inputs.dry_run == false
shell: bash -eux {0}
run: |
git push --force origin refs/tags/v3:refs/tags/v3
REFS=("HEAD:refs/heads/${GITHUB_REF_NAME}" "refs/tags/${TAG}:refs/tags/${TAG}")
if [ "${IS_V3}" = "true" ]; then
REFS+=("+refs/tags/v3:refs/tags/v3")
fi
git push --atomic origin "${REFS[@]}"
echo "Pushed ${GITHUB_REF_NAME}, ${TAG}$([ "${IS_V3}" = "true" ] && echo ", and v3")" >> "$GITHUB_STEP_SUMMARY"

- name: Warn about floating tag retirement
if: env.IS_V3 != 'true'
shell: bash
run: |
MESSAGE="Release v${NEXT_VERSION} no longer uses floating tags. Open a PR removing the floating-tag-update steps (Create/Push v3 tag, and this warning) from .github/workflows/release.yml."
MESSAGE="Release v${NEXT_VERSION} no longer uses floating tags. Open a PR removing the floating-tag-update logic and this warning from .github/workflows/release.yml."
echo "::warning::$MESSAGE"
echo "$MESSAGE" >> "$GITHUB_STEP_SUMMARY"

Expand Down
Loading