Repository navigation
[Client] Mark the client disconnected when the stdio server exits - #573
Open
chr-hertel wants to merge 1 commit into
Open
chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
chr-hertel
added
bug
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #547 a call to an exited stdio server fails at once, but
isConnected()stays true and later calls go against the dead process.StdioTransportmarks the client uninitialized when the server closes its output or can no longer be written tostate->setInitialized(false)), so the two compose - [Client] Invalidate expired HTTP sessions #560 covers the HTTP side ([Client] A lost HTTP session leaves the client connected chr-hertel/php-sdk#66)Fixes chr-hertel#71
🤖 Generated with Claude Code