Repository navigation
[Server] Stop the handshake-era SSE loop once the client disconnected - #569
Merged
chr-hertel merged 1 commit intoOct 13, 2026
Merged
Conversation
chr-hertel
force-pushed
the
fix-sse-abandoned-stream
branch
from
October 10, 2026 01:55
c3aa3ec to
eee8070
Compare
chr-hertel
added
bug
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The abort path leaves the awaited request persisted in session state.
1 open finding
What changed in this PR
Stops handshake-era SSE polling after client disconnection, preventing PHP worker exhaustion.
Changes:
- Sends periodic SSE keep-alive comments to detect disconnects.
- Exits polling when the connection aborts.
- Adds regression coverage and changelog documentation.
| File | Description |
|---|---|
src/Server/Transport/StreamableHttpTransport.php |
Adds keep-alives and disconnect handling. |
tests/Unit/Server/Transport/StreamableHttpTransportTest.php |
Tests disconnected-client behavior. |
CHANGELOG.md |
Documents the fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+350
to
+353
| if ($this->isConnectionAborted()) { | ||
| $this->logger->info('SSE: Client disconnected, dropping the suspended request.'); | ||
|
|
||
| return; |
chr-hertel
force-pushed
the
fix-sse-abandoned-stream
branch
2 times, most recently
from
October 12, 2026 23:27
980d5a9 to
da06f4a
Compare
soyuka
previously approved these changes
Oct 13, 2026
chr-hertel
force-pushed
the
fix-sse-abandoned-stream
branch
from
October 13, 2026 22:00
da06f4a to
022503f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client that disconnects while its call waits on an elicitation kept the PHP worker polling until the request timed out (120s by default) - the loop never checked
connection_aborted(),StatelessProtocolalready does.: keep-alivecomment every 250ms (same pace as the stateless keep-alive), since PHP only notices a dropped peer when it writesisConnectionAborted()to keep it testableFixes chr-hertel#60
🤖 Generated with Claude Code