Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![jetbrains-air[bot]](https://avatars.githubusercontent.com/in/3314082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good — the unknown-tool path now mirrors the existing unknown-prompt handling, and the transport coverage is a nice touch, so this is good to merge.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=7f2373f6-0656-49c7-bc7f-347e4592fe4f
There was a problem hiding this comment.
Looks good — this matches the spec and the existing unknown-prompt handling nicely, approving.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=3ba94be9-8d76-4333-ab41-dc6853851136
There was a problem hiding this comment.
Looks good — the unknown-tool path now returns a proper protocol error and the change reads cleanly, so this is approved.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=29247b13-6ba1-4d6f-b0ac-4761ffc0981b
There was a problem hiding this comment.
Looks good — the unknown-tool path now returns a proper protocol error, so this is approved.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=01917bbe-be87-4b5e-a50a-8e833cd08b0b
There was a problem hiding this comment.
Looks good — the unknown-tool path now returns the protocol error the spec calls for, so this is good to merge.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=dd9b933d-c871-44a3-97ec-628b87fd773b
There was a problem hiding this comment.
Nice work — this lines the unknown-tool path up with the spec and the existing prompt/resource handling, so it's approved.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=98734216-dfa8-48d2-ab57-a9b34c608d0c
There was a problem hiding this comment.
Looks good — the unknown-tool path now returns the protocol error the spec asks for, so this is approved.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=1a73fe02-b865-4cc6-b6ca-35d4e7f46637
Motivation and Context
Fixes #1037.
Calling an unregistered tool currently returns a normal result with
isError = true, making it indistinguishable from a tool execution failure. Return a JSON-RPCINVALID_PARAMSerror (-32602) instead, matching the tools specification and existing unknown-prompt handling. Registered tool handlers still return execution failures throughisError.How Has This Been Tested?
mainbecause no protocol exception reaches the client; all 36 focused tests pass with the fix.checkKotlinAbi) and server static analysis (detektMainJvm) pass.Breaking Changes
As requested in #1037, callers now receive a protocol exception for unknown or removed tools rather than a
CallToolResultwithisError = true. No public signatures change.Types of changes
Checklist
Additional context
Prepared with Codex assistance for issue investigation, implementation and local validation.