Repository navigation
Fix enterprise IdP metadata for strict OIDC discovery - #574
Open
fitchmultz wants to merge 1 commit into
Open
fitchmultz wants to merge 1 commit into
fitchmultz wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #573.
The enterprise authorization fixture now supplies the required OIDC discovery fields, allowing strict SDK discovery to reach the existing token exchanges. Its pre-issued ID token uses RS256, which OIDC Discovery requires providers to advertise; the advertised algorithm and real key/signature now agree. ID-JAG signing and all scenario checks remain unchanged.
The added test calls the SDK's real discovery helper against the running fixture. Before the fix it fails with the three missing-array diagnostics. Afterward it verifies discovery, endpoints, subject type and the issued token's advertised algorithm. The existing complete-flow tests still exercise both exchanges.
Verification:
npm run buildpassed.npm testpassed: 642 tests in 48 files.npm run checkpassed on macOS with the installed native compiler, ESLint and Prettier.